This is an archive of the discontinued LLVM Phabricator instance.

Differential D54339

Fix threads detection on GNU/Hurd
ClosedPublic

Authored by sthibaul on Nov 9 2018, 11:28 AM.

Details

Reviewers
EricWF
howard.hinnant
joerg
ldionne
mclow.lists
krytarowski
Summary

GNU/Hurd provides standard Posix threads

Diff Detail

Repository
rCXX libc++

Event Timeline

sthibaul created this revision.Nov 9 2018, 11:28 AM
Herald added subscribers: libcxx-commits, ldionne, krytarowski. · View Herald TranscriptNov 9 2018, 11:28 AM
sthibaul added reviewers: ldionne, mclow.lists.Nov 17 2018, 7:52 AM
krytarowski accepted this revision.Nov 17 2018, 8:07 AM
This revision is now accepted and ready to land.Nov 17 2018, 8:07 AM
sthibaul added a comment.Nov 18 2018, 2:35 PM

(I can't commit this myself)

ldionne requested changes to this revision.Nov 19 2018, 7:49 AM
ldionne added inline comments.
include/__config
1146

According to https://sourceforge.net/p/predef/wiki/OperatingSystems/, an equivalent way of checking that would be __gnu_hurd__. I would prefer that as it is more explicit. Otherwise LGTM.

This revision now requires changes to proceed.Nov 19 2018, 7:49 AM
krytarowski added inline comments.Nov 19 2018, 8:02 AM
include/__config
1146

__GNU__ is well established constant, used in the wild. I've never seen __gnu_hurd__ myself, it souds like __gnu_linux__...

ldionne accepted this revision.Nov 19 2018, 8:06 AM
ldionne added inline comments.
include/__config
1146

Ok.

This revision is now accepted and ready to land.Nov 19 2018, 8:06 AM
sthibaul marked 3 inline comments as done.Nov 20 2018, 12:28 PM
ldionne closed this revision.Nov 20 2018, 1:17 PM

Committed as r347347.

Revision Contents

PathSize
include/
1 line

Diff 173395

include/__config

Show First 20 Lines • Show All 1,137 Lines • ▼ Show 20 Lines
#if !defined(_LIBCPP_HAS_NO_THREADS) && \ #if !defined(_LIBCPP_HAS_NO_THREADS) && \
!defined(_LIBCPP_HAS_THREAD_API_PTHREAD) && \ !defined(_LIBCPP_HAS_THREAD_API_PTHREAD) && \
!defined(_LIBCPP_HAS_THREAD_API_WIN32) && \ !defined(_LIBCPP_HAS_THREAD_API_WIN32) && \
!defined(_LIBCPP_HAS_THREAD_API_EXTERNAL) !defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
# if defined(__FreeBSD__) || \ # if defined(__FreeBSD__) || \
defined(__Fuchsia__) || \ defined(__Fuchsia__) || \
defined(__NetBSD__) || \ defined(__NetBSD__) || \
defined(__linux__) || \ defined(__linux__) || \
defined(__GNU__) || \
ldionneUnsubmitted
Done
ReplyInline Actions

According to https://sourceforge.net/p/predef/wiki/OperatingSystems/, an equivalent way of checking that would be __gnu_hurd__. I would prefer that as it is more explicit. Otherwise LGTM.

ldionne: According to https://sourceforge.net/p/predef/wiki/OperatingSystems/, an equivalent way of…
krytarowskiUnsubmitted
Done
ReplyInline Actions

__GNU__ is well established constant, used in the wild. I've never seen __gnu_hurd__ myself, it souds like __gnu_linux__...

krytarowski: `__GNU__` is well established constant, used in the wild. I've never seen `__gnu_hurd__` myself…
ldionneUnsubmitted
Done
ReplyInline Actions

Ok.

ldionne: Ok.
defined(__APPLE__) || \ defined(__APPLE__) || \
defined(__CloudABI__) || \ defined(__CloudABI__) || \
defined(__sun__) || \ defined(__sun__) || \
(defined(__MINGW32__) && __has_include(<pthread.h>)) (defined(__MINGW32__) && __has_include(<pthread.h>))
# define _LIBCPP_HAS_THREAD_API_PTHREAD # define _LIBCPP_HAS_THREAD_API_PTHREAD
# elif defined(_LIBCPP_WIN32API) # elif defined(_LIBCPP_WIN32API)
# define _LIBCPP_HAS_THREAD_API_WIN32 # define _LIBCPP_HAS_THREAD_API_WIN32
# else # else
▲ Show 20 Lines • Show All 260 Lines • Show Last 20 Lines