Page MenuHomePhabricator
Differential D54290

[libcxx] Provide thread annotations for shared_mutex
ClosedPublic
Actions

Authored by phosek on Nov 8 2018, 8:29 PM.

Details

Reviewers
ldionne
EricWF
mclow.lists
Commits
rGf30c0117c890: [libcxx] Provide thread annotations for shared_mutex
rCXX346567: [libcxx] Provide thread annotations for shared_mutex
rL346567: [libcxx] Provide thread annotations for shared_mutex
Summary

shared_mutex was introduced in C++17 but its implementation currently
doesn't use Clang's thread annotations like regular mutex. This change
adds those.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Nov 8 2018, 8:29 PM
Herald added subscribers: libcxx-commits, christof. · View Herald TranscriptNov 8 2018, 8:29 PM
ldionne accepted this revision.Nov 9 2018, 8:41 AM
ldionne added inline comments.
libcxx/include/shared_mutex
164 ↗(On Diff #173265)

Just making sure; those are only needed on the declarations?

This revision is now accepted and ready to land.Nov 9 2018, 8:41 AM
phosek marked an inline comment as done.Nov 9 2018, 11:54 AM
phosek added inline comments.
libcxx/include/shared_mutex
164 ↗(On Diff #173265)

Yes

Closed by commit rL346567: [libcxx] Provide thread annotations for shared_mutex (authored by phosek). · Explain WhyNov 9 2018, 3:35 PM
This revision was automatically updated to reflect the committed changes.
phosek marked an inline comment as done.
Herald added a subscriber: llvm-commits. · View Herald TranscriptNov 9 2018, 3:35 PM

Revision Contents
Changeset List

PathSize
libcxx/
trunk/
include/
15 lines

Diff 173460

View Options

libcxx/trunk/include/shared_mutex

Loading...