This moves construction of data buffers into the FileSystem class. Like some of the previous refactorings we don't translate the path yet because the functionality hasn't been landed in LLVM yet.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Looks fine to me, I'd just ask you to consider shortening the method names a bit.
include/lldb/Host/FileSystem.h | ||
---|---|---|
119–122 | Can we streamline these names? I don't think the FromPath part brings anything here when the method is on the filesystem class, as it's completely natural and expected for those methods to take paths. Maybe just CreateDataBuffer or ToDataBuffer |
Can we streamline these names? I don't think the FromPath part brings anything here when the method is on the filesystem class, as it's completely natural and expected for those methods to take paths. Maybe just CreateDataBuffer or ToDataBuffer