Page Menu
Home
Phabricator
This is an archive of the discontinued LLVM Phabricator instance.
Paths
Table of Contents
t
-
libcxx/trunk/include/
-
trunk/
-
include/
-
utility
Hide Panel
f
Keyboard Reference
?
Differential
D54234
Fix -Wimplicit-fallthrough warning
Closed
Public
Authored by
MaskRay
on Nov 7 2018, 3:13 PM.
Download Raw Diff
Details
Reviewers
EricWF
ldionne
mclow.lists
Commits
rG892bbd3f88b9: Fix -Wimplicit-fallthrough warning
rCXX346369: Fix -Wimplicit-fallthrough warning
rL346369: Fix -Wimplicit-fallthrough warning
Diff Detail
Repository
rL LLVM
Event Timeline
MaskRay
created this revision.
Nov 7 2018, 3:13 PM
Herald
added subscribers:
libcxx-commits
,
christof
.
·
View Herald Transcript
Nov 7 2018, 3:13 PM
Harbormaster
completed remote builds in
B24701: Diff 173048
.
Nov 7 2018, 3:15 PM
ldionne
accepted this revision.
Nov 7 2018, 3:45 PM
Comment Actions
LGTM. I'm just hoping the fallthrough is indeed intended here. :-)
This revision is now accepted and ready to land.
Nov 7 2018, 3:45 PM
Closed by commit
rL346369: Fix -Wimplicit-fallthrough warning
(authored by
MaskRay
).
·
Explain Why
Nov 7 2018, 3:54 PM
This revision was automatically updated to reflect the committed changes.
Herald
added a subscriber:
llvm-commits
.
·
View Herald Transcript
Nov 7 2018, 3:54 PM