This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Support creation and import of shared memories
ClosedPublic

Authored by dschuff on Nov 5 2018, 5:33 PM.

Event Timeline

dschuff created this revision.Nov 5 2018, 5:33 PM
sbc100 accepted this revision.Nov 6 2018, 8:42 AM

Nice!

wasm/Writer.cpp
160

No curly braces for single line blocks

220

For consistency maybe:

unsigned Flags = 0;
if (HasMax)
   Flags |= WASM_LIMITS_FLAG_HAS_MAX;
This revision is now accepted and ready to land.Nov 6 2018, 8:42 AM
This revision was automatically updated to reflect the committed changes.