Page MenuHomePhabricator

[lld][NFC] Update tests to use -S instead of -s when using llvm-readelf.
ClosedPublic

Authored by rupprecht on Nov 5 2018, 12:01 PM.

Details

Summary

llvm-readobj/readelf accepts both -s and -S as aliases for --sections. However with GNU readelf only -S means --section, and -s means --symbols. I would like to make llvm-readelf more compatible.

Diff Detail

Repository
rL LLVM

Event Timeline

rupprecht created this revision.Nov 5 2018, 12:01 PM
MaskRay accepted this revision.Nov 5 2018, 12:05 PM

If the initial attempt to bring the -s incompatibility in llvm-readelf was inadvertent, let's improve it!

This revision is now accepted and ready to land.Nov 5 2018, 12:05 PM

If the initial attempt to bring the -s incompatibility in llvm-readelf was inadvertent, let's improve it!

There are 455 failures when removing the alias :)
If we just change the aliases for llvm-readelf, not llvm-readobj, then these are pretty much the only failures.

This revision was automatically updated to reflect the committed changes.