Page MenuHomePhabricator

[LegacyPassManager] Add NL to -print-before/-print-after banner
Needs RevisionPublic

Authored by tpr on Nov 5 2018, 5:13 AM.

Details

Summary

Change-Id: Idc93e09a9b24ba723bf9f7cad315885eeb62916c

Diff Detail

Event Timeline

tpr created this revision.Nov 5 2018, 5:13 AM
tpr added a reviewer: chandlerc.
tpr added a subscriber: dstuttard.
fedor.sergeev requested changes to this revision.Nov 5 2018, 6:59 AM

I believe this is not a right place for a fix.
Banner in some cases is just a prefix for a full banner line
(see PrintFunctionPass::run, handling for forcePrintModuleIR).

So the right way to fix is to add \n in a couple of places where it is still missing
(say, in PrintFunctionPass::run, else branch of forcePrintModuleIR condition).

This revision now requires changes to proceed.Nov 5 2018, 6:59 AM