This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Turn assert into condition in ARMCGP
ClosedPublic

Authored by samparker on Nov 5 2018, 2:26 AM.

Details

Summary

Turn the assert in PrepareConstants into a conditon so that we can handle mul instructions with negative immediates.

Diff Detail

Event Timeline

samparker created this revision.Nov 5 2018, 2:26 AM
SjoerdMeijer accepted this revision.Nov 5 2018, 3:03 AM

Looks like a straightforward fix/addition to me.

test/CodeGen/ARM/CGP/arm-cgp-icmps.ll
324

nit: to test a mul with a negative number, we can probably have a more minimal example (we don't need a store, load, trunc, and).

This revision is now accepted and ready to land.Nov 5 2018, 3:03 AM
This revision was automatically updated to reflect the committed changes.