This is an archive of the discontinued LLVM Phabricator instance.

Differential D54054

Split lgammal() from INIT_LGAMMAL
ClosedPublic

Authored by krytarowski on Nov 2 2018, 3:02 PM.

Details

Reviewers
joerg
vitalybuka
Commits
rGe06fb482a94f: Split lgammal() from INIT_LGAMMAL
rL346352: Split lgammal() from INIT_LGAMMAL
rCRT346352: Split lgammal() from INIT_LGAMMAL
Summary

Introduce SANITIZER_INTERCEPT_LGAMMAL
dedicated for lgammal(). Disable it for NetBSD
as this routine is not implemented in this OS.

Installation of supernumerary interceptors causes
leaking of errors to dlsym(3)-like operations.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski created this revision.Nov 2 2018, 3:02 PM
Herald added subscribers: llvm-commits, kubamracek. · View Herald TranscriptNov 2 2018, 3:02 PM
krytarowski edited the summary of this revision. (Show Details)Nov 6 2018, 6:00 PM
krytarowski added a comment.Nov 7 2018, 5:06 AM

Ping?

vitalybuka accepted this revision.Nov 7 2018, 12:20 PM
This revision is now accepted and ready to land.Nov 7 2018, 12:20 PM
Closed by commit rCRT346352: Split lgammal() from INIT_LGAMMAL (authored by kamil). · Explain WhyNov 7 2018, 12:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 172444

lib/sanitizer_common/sanitizer_common_interceptors.inc

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,864 Lines • ▼ Show 20 Lines
} }
INTERCEPTOR(float, lgammaf, float x) { INTERCEPTOR(float, lgammaf, float x) {
void *ctx; void *ctx;
COMMON_INTERCEPTOR_ENTER(ctx, lgammaf, x); COMMON_INTERCEPTOR_ENTER(ctx, lgammaf, x);
float res = REAL(lgammaf)(x); float res = REAL(lgammaf)(x);
COMMON_INTERCEPTOR_WRITE_RANGE(ctx, &signgam, sizeof(signgam)); COMMON_INTERCEPTOR_WRITE_RANGE(ctx, &signgam, sizeof(signgam));
return res; return res;
} }
#define INIT_LGAMMA \
COMMON_INTERCEPT_FUNCTION(lgamma); \
COMMON_INTERCEPT_FUNCTION(lgammaf);
#else
#define INIT_LGAMMA
#endif
#if SANITIZER_INTERCEPT_LGAMMAL
INTERCEPTOR(long double, lgammal, long double x) { INTERCEPTOR(long double, lgammal, long double x) {
void *ctx; void *ctx;
COMMON_INTERCEPTOR_ENTER(ctx, lgammal, x); COMMON_INTERCEPTOR_ENTER(ctx, lgammal, x);
long double res = REAL(lgammal)(x); long double res = REAL(lgammal)(x);
COMMON_INTERCEPTOR_WRITE_RANGE(ctx, &signgam, sizeof(signgam)); COMMON_INTERCEPTOR_WRITE_RANGE(ctx, &signgam, sizeof(signgam));
return res; return res;
} }
#define INIT_LGAMMA \ #define INIT_LGAMMAL \
COMMON_INTERCEPT_FUNCTION(lgamma); \
COMMON_INTERCEPT_FUNCTION(lgammaf); \
COMMON_INTERCEPT_FUNCTION_LDBL(lgammal); COMMON_INTERCEPT_FUNCTION_LDBL(lgammal);
#else #else
#define INIT_LGAMMA #define INIT_LGAMMAL
#endif #endif
#if SANITIZER_INTERCEPT_LGAMMA_R #if SANITIZER_INTERCEPT_LGAMMA_R
INTERCEPTOR(double, lgamma_r, double x, int *signp) { INTERCEPTOR(double, lgamma_r, double x, int *signp) {
void *ctx; void *ctx;
COMMON_INTERCEPTOR_ENTER(ctx, lgamma_r, x, signp); COMMON_INTERCEPTOR_ENTER(ctx, lgamma_r, x, signp);
// FIXME: under ASan the call below may write to freed memory and corrupt // FIXME: under ASan the call below may write to freed memory and corrupt
// its metadata. See // its metadata. See
▲ Show 20 Lines • Show All 2,529 Lines • ▼ Show 20 Linesstatic void InitializeCommonInterceptors() {
INIT_TMPNAM_R; INIT_TMPNAM_R;
INIT_TTYNAME_R; INIT_TTYNAME_R;
INIT_TEMPNAM; INIT_TEMPNAM;
INIT_PTHREAD_SETNAME_NP; INIT_PTHREAD_SETNAME_NP;
INIT_PTHREAD_GETNAME_NP; INIT_PTHREAD_GETNAME_NP;
INIT_SINCOS; INIT_SINCOS;
INIT_REMQUO; INIT_REMQUO;
INIT_LGAMMA; INIT_LGAMMA;
INIT_LGAMMAL;
INIT_LGAMMA_R; INIT_LGAMMA_R;
INIT_LGAMMAL_R; INIT_LGAMMAL_R;
INIT_DRAND48_R; INIT_DRAND48_R;
INIT_RAND_R; INIT_RAND_R;
INIT_GETLINE; INIT_GETLINE;
INIT_ICONV; INIT_ICONV;
INIT_TIMES; INIT_TIMES;
INIT_TLS_GET_ADDR; INIT_TLS_GET_ADDR;
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines

lib/sanitizer_common/sanitizer_platform_interceptors.h

Show First 20 Lines • Show All 355 Lines • ▼ Show 20 Lines
#define SANITIZER_INTERCEPT_THR_EXIT SI_FREEBSD #define SANITIZER_INTERCEPT_THR_EXIT SI_FREEBSD
#define SANITIZER_INTERCEPT_TMPNAM SI_POSIX #define SANITIZER_INTERCEPT_TMPNAM SI_POSIX
#define SANITIZER_INTERCEPT_TMPNAM_R SI_LINUX_NOT_ANDROID || SI_SOLARIS #define SANITIZER_INTERCEPT_TMPNAM_R SI_LINUX_NOT_ANDROID || SI_SOLARIS
#define SANITIZER_INTERCEPT_TTYNAME_R SI_POSIX #define SANITIZER_INTERCEPT_TTYNAME_R SI_POSIX
#define SANITIZER_INTERCEPT_TEMPNAM SI_POSIX #define SANITIZER_INTERCEPT_TEMPNAM SI_POSIX
#define SANITIZER_INTERCEPT_SINCOS SI_LINUX || SI_SOLARIS #define SANITIZER_INTERCEPT_SINCOS SI_LINUX || SI_SOLARIS
#define SANITIZER_INTERCEPT_REMQUO SI_POSIX #define SANITIZER_INTERCEPT_REMQUO SI_POSIX
#define SANITIZER_INTERCEPT_LGAMMA SI_POSIX #define SANITIZER_INTERCEPT_LGAMMA SI_POSIX
#define SANITIZER_INTERCEPT_LGAMMAL (SI_POSIX && !SI_NETBSD)
#define SANITIZER_INTERCEPT_LGAMMA_R (SI_FREEBSD || SI_LINUX || SI_SOLARIS) #define SANITIZER_INTERCEPT_LGAMMA_R (SI_FREEBSD || SI_LINUX || SI_SOLARIS)
#define SANITIZER_INTERCEPT_LGAMMAL_R SI_LINUX_NOT_ANDROID || SI_SOLARIS #define SANITIZER_INTERCEPT_LGAMMAL_R SI_LINUX_NOT_ANDROID || SI_SOLARIS
#define SANITIZER_INTERCEPT_DRAND48_R SI_LINUX_NOT_ANDROID #define SANITIZER_INTERCEPT_DRAND48_R SI_LINUX_NOT_ANDROID
#define SANITIZER_INTERCEPT_RAND_R \ #define SANITIZER_INTERCEPT_RAND_R \
(SI_FREEBSD || SI_NETBSD || SI_OPENBSD || SI_MAC || SI_LINUX_NOT_ANDROID || \ (SI_FREEBSD || SI_NETBSD || SI_OPENBSD || SI_MAC || SI_LINUX_NOT_ANDROID || \
SI_SOLARIS) SI_SOLARIS)
#define SANITIZER_INTERCEPT_ICONV \ #define SANITIZER_INTERCEPT_ICONV \
(SI_FREEBSD || SI_NETBSD || SI_OPENBSD || SI_LINUX_NOT_ANDROID || SI_SOLARIS) (SI_FREEBSD || SI_NETBSD || SI_OPENBSD || SI_LINUX_NOT_ANDROID || SI_SOLARIS)
▲ Show 20 Lines • Show All 147 Lines • Show Last 20 Lines