This is an archive of the discontinued LLVM Phabricator instance.

Remove working directory for debugserver code signing target
ClosedPublic

Authored by lanza on Oct 31 2018, 5:31 PM.

Details

Summary

LLVM puts output binaries in
${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin. This chunk of
code left out the ${CMAKE_CFG_INTDIR}. Ultimately, the code signing target
does not need a working directory anyways, so it's safe to just remove it.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

lanza created this revision.Oct 31 2018, 5:31 PM
beanz added a comment.Nov 6 2018, 9:31 AM

Honestly, I don't know that we need to specify a working directory on this command at all. Since we're specifying the target file using a generator expression everything else should work because we use explicit not relative paths.

lanza updated this revision to Diff 172815.Nov 6 2018, 11:55 AM

remove working directory

lanza added a comment.Nov 6 2018, 11:57 AM

Good point, updated accordingly.

lanza retitled this revision from Change a hardcoded build/bin path to use the full LLVM output intdir to Remove working directory for debugserver code signing target.Nov 6 2018, 1:22 PM
lanza edited the summary of this revision. (Show Details)
beanz accepted this revision.Nov 6 2018, 2:55 PM

LGTM

This revision is now accepted and ready to land.Nov 6 2018, 2:55 PM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.