This is an archive of the discontinued LLVM Phabricator instance.

[builtins] Re-enable x86-only long double tests
ClosedPublic

Authored by rnk on Oct 29 2018, 3:11 PM.

Details

Summary

In r81552, the HAS_80_BIT_LONG_DOUBLE macro was added to the unit test
only version of int_lib.h. One month later in r85260 the duplicate
int_lib.h was removed, but the tests still passed because we don't build
with -Werror.

This is the minimal change to bring it back, and I decided to put the
configuration macro next to our 128-bit integer support macro.

Event Timeline

rnk created this revision.Oct 29 2018, 3:11 PM
joerg added a comment.Oct 30 2018, 5:58 AM

__m68k__ and __ia64__ too, just for completeness.

LGTM, modulo Joerg's comment.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 30 2018, 1:54 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: Restricted Project. · View Herald TranscriptOct 30 2018, 1:54 PM