Page MenuHomePhabricator

Make instrprof-set-dir-mode test tolerant of group ID
AcceptedPublic

Authored by troyj on Oct 29 2018, 1:56 PM.

Details

Reviewers
probinson
mattd
Summary

Hi, I ran into a problem with this test when the source was located in certain directories. The mkdir(2) man page states that the set-group-ID bit is inherited from the parent directory, but this test was written in such a way that it assumes the bit is unset. Whether that assumption is true depends on where the checkout lives, which leads to some people being able to reproduce the problem whereas others cannot. I think the correct fix is to exclude the bit from the check.

Making probinson a reviewer since they reviewed the original test.

Diff Detail

Event Timeline

troyj created this revision.Oct 29 2018, 1:56 PM
Herald added subscribers: Restricted Project, llvm-commits. ยท View Herald TranscriptOct 29 2018, 1:56 PM

+ Matt Davis who wrote the test
Sorry for the delay; feel free to add a 'ping' reply every week or so when you get no action.
Seems right to me but I think Matt would be a better choice to review.

mattd accepted this revision.Dec 3 2018, 10:55 AM

@troyj, good catch! Thanks, and LGTM.

This revision is now accepted and ready to land.Dec 3 2018, 10:55 AM