This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC.
ClosedPublic

Authored by vsapsai on Oct 25 2018, 12:30 PM.

Event Timeline

vsapsai created this revision.Oct 25 2018, 12:30 PM

This should at least be named emitScalarConstant.

vsapsai updated this revision to Diff 171751.Oct 30 2018, 11:48 AM
  • Rename EmitConstant to EmitScalarConstant.

This should at least be named emitScalarConstant.

Agree. I've just capitalized 'e' as it looks like the majority of Emit... methods are capitalized that way.

rjmccall accepted this revision.Oct 30 2018, 6:10 PM

Well, that's the old style, but we've been slowly moving to the camelCase style instead. Very, very slowly. I won't hold up your patch over it.

This revision is now accepted and ready to land.Oct 30 2018, 6:10 PM
vsapsai updated this revision to Diff 172046.Oct 31 2018, 4:25 PM
  • Switch to camelCase.
rjmccall accepted this revision.Oct 31 2018, 4:30 PM

Thanks. Still LGTM. :)

Can you please check https://reviews.llvm.org/D53674 ? It builds on top of this change and I plan to commit them together.

This revision was automatically updated to reflect the committed changes.