This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Don't invalidate LSP-set compile commands when closing a file.
ClosedPublic

Authored by sammccall on Oct 24 2018, 6:09 AM.

Details

Summary

It doesn't make much sense: setting them is not coupled to opening the file,
it's an asynchronous notification.

I don't think this is a breaking change - this behavior is hard to observe!

Event Timeline

sammccall created this revision.Oct 24 2018, 6:09 AM
ilya-biryukov accepted this revision.Oct 24 2018, 9:55 AM

LGTM. Good catch!

This revision is now accepted and ready to land.Oct 24 2018, 9:55 AM
This revision was automatically updated to reflect the committed changes.