Page MenuHomePhabricator

Don't type-erase the FunctionNameType or TypeClass enums

Authored by zturner on Oct 23 2018, 3:06 PM.



This is a followup to D53597, with 2 more enums. Assuming that patch is good, I see no reason why this wasn't isn't good as well, but I'm throwing it out here for review anyway if nothing else as an FYI. I'll wait for a final LGTM on D53597, but assuming that's good, I'll probably submit both of these unless someone has a comment or comments on this one first.

I think this is the last of the type-erased enums, so after this, all of our flags enums should be strongly typed through the system.

Diff Detail


Event Timeline

zturner created this revision.Oct 23 2018, 3:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 25 2018, 1:48 PM
This revision was automatically updated to reflect the committed changes.