This is an archive of the discontinued LLVM Phabricator instance.

Differential D53569

[MinGW] Enable large file for mingw-w64
ClosedPublic

Authored by SquallATF on Oct 23 2018, 6:28 AM.

Details

Reviewers
mstorsjo
Commits
rGc4a995c8e05b: [MinGW] Enable large file for mingw-w64
rL345131: [MinGW] Enable large file for mingw-w64
Summary

64-bit mingw not define _FILE_OFFSET_BITS=64 default.

Diff Detail

Event Timeline

SquallATF created this revision.Oct 23 2018, 6:28 AM
Herald added subscribers: llvm-commits, mgorny. · View Herald TranscriptOct 23 2018, 6:28 AM
Harbormaster completed remote builds in B24072: Diff 170627.Oct 23 2018, 6:28 AM
mstorsjo accepted this revision.Oct 23 2018, 12:35 PM
mstorsjo added a subscriber: mstorsjo.

This is fine I think, although I haven't tested it myself.

This revision is now accepted and ready to land.Oct 23 2018, 12:35 PM
Closed by commit rL345131: [MinGW] Enable large file for mingw-w64 (authored by mstorsjo). · Explain WhyOct 24 2018, 5:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cmake/
modules/
4 lines

Diff 170627

cmake/modules/HandleLLVMOptions.cmake

Show First 20 Lines • Show All 218 Lines • ▼ Show 20 Lines
endif() endif()
if(NOT WIN32 AND NOT CYGWIN) if(NOT WIN32 AND NOT CYGWIN)
# MinGW warns if -fvisibility-inlines-hidden is used. # MinGW warns if -fvisibility-inlines-hidden is used.
check_cxx_compiler_flag("-fvisibility-inlines-hidden" SUPPORTS_FVISIBILITY_INLINES_HIDDEN_FLAG) check_cxx_compiler_flag("-fvisibility-inlines-hidden" SUPPORTS_FVISIBILITY_INLINES_HIDDEN_FLAG)
append_if(SUPPORTS_FVISIBILITY_INLINES_HIDDEN_FLAG "-fvisibility-inlines-hidden" CMAKE_CXX_FLAGS) append_if(SUPPORTS_FVISIBILITY_INLINES_HIDDEN_FLAG "-fvisibility-inlines-hidden" CMAKE_CXX_FLAGS)
endif() endif()
if(CMAKE_SIZEOF_VOID_P EQUAL 8 AND MINGW)
add_definitions( -D_FILE_OFFSET_BITS=64 )
endif()
if( CMAKE_SIZEOF_VOID_P EQUAL 8 AND NOT WIN32 ) if( CMAKE_SIZEOF_VOID_P EQUAL 8 AND NOT WIN32 )
# TODO: support other platforms and toolchains. # TODO: support other platforms and toolchains.
if( LLVM_BUILD_32_BITS ) if( LLVM_BUILD_32_BITS )
message(STATUS "Building 32 bits executables and libraries.") message(STATUS "Building 32 bits executables and libraries.")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -m32") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -m32")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -m32") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -m32")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -m32") set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -m32")
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -m32") set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -m32")
▲ Show 20 Lines • Show All 664 Lines • Show Last 20 Lines