This is an archive of the discontinued LLVM Phabricator instance.

Differential D53529

[Driver] fix broken test
ClosedPublic

Authored by nickdesaulniers on Oct 22 2018, 2:19 PM.

Details

Reviewers
srhines
danalbert
Commits
rG791cfad3069f: [Driver] fix broken test
rC344958: [Driver] fix broken test
rL344958: [Driver] fix broken test
Summary

Fixes test from r344941 which was broken on Windows. We want to check
the selected toolchain rather than the found toolchain anyways.

Diff Detail

Repository
rL LLVM

Event Timeline

nickdesaulniers created this revision.Oct 22 2018, 2:19 PM
Herald added a subscriber: cfe-commits. · View Herald TranscriptOct 22 2018, 2:19 PM
Harbormaster completed remote builds in B24025: Diff 170494.Oct 22 2018, 2:20 PM
srhines accepted this revision.Oct 22 2018, 2:25 PM
This revision is now accepted and ready to land.Oct 22 2018, 2:25 PM
Closed by commit rL344958: [Driver] fix broken test (authored by nickdesaulniers). · Explain WhyOct 22 2018, 2:28 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptOct 22 2018, 2:28 PM

Revision Contents

PathSize
cfe/
trunk/
test/
Driver/
2 lines

Diff 170499

cfe/trunk/test/Driver/android-gcc-toolchain.c

// Test that gcc-toolchain option works correctly with a aarch64-linux-gnu // Test that gcc-toolchain option works correctly with a aarch64-linux-gnu
// triple. // triple.
// //
// RUN: %clang %s -### -v --target=aarch64-linux-gnu \ // RUN: %clang %s -### -v --target=aarch64-linux-gnu \
// RUN: --gcc-toolchain=%S/Inputs/basic_android_ndk_tree/ 2>&1 \ // RUN: --gcc-toolchain=%S/Inputs/basic_android_ndk_tree/ 2>&1 \
// RUN: | FileCheck %s // RUN: | FileCheck %s
// //
// CHECK: Found candidate GCC installation: {{.*}}/Inputs/basic_android_ndk_tree/lib/gcc/aarch64-linux-android/4.9 // CHECK: Selected GCC installation: {{.*}}/Inputs/basic_android_ndk_tree/lib/gcc/aarch64-linux-android/4.9