Page MenuHomePhabricator

[llvm-exegesis] ExecutionMode is computed upfront for Uops as well
Needs ReviewPublic

Authored by gchatelet on Oct 22 2018, 8:12 AM.

Details

Reviewers
courbet

Diff Detail

Event Timeline

gchatelet created this revision.Oct 22 2018, 8:12 AM
courbet added inline comments.Oct 26 2018, 12:15 AM
tools/llvm-exegesis/lib/CodeTemplate.h
87

s/each memory access hits a different cache line/memory accesses do not alias/

tools/llvm-exegesis/lib/Latency.cpp
134

Let's commit this separately.

tools/llvm-exegesis/lib/MCInstrDescView.h
98

I think it would be better to return a vector<const Variable*> and deal with unicity at the call site.

141

*writes

tools/llvm-exegesis/lib/Uops.h
38

doc ?

courbet added inline comments.Oct 26 2018, 12:22 AM
tools/llvm-exegesis/lib/Uops.cpp
102

...for non-memory purposes

180

"missing ScratchSpaceReg" would be clearer

233

please add a comment here

247

ditto

256

this doe snot need to be a member

Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2019, 10:07 AM