This is an archive of the discontinued LLVM Phabricator instance.

Differential D53499

[llvm-exegesis] Mark x86 segment register instructions as unsupported.
ClosedPublic

Authored by gchatelet on Oct 22 2018, 7:56 AM.

Details

Reviewers
courbet
Commits
rG02f70a3fde98: [llvm-exegesis] Mark x86 segment register instructions as unsupported.
rL344906: [llvm-exegesis] Mark x86 segment register instructions as unsupported.

Diff Detail

Event Timeline

gchatelet created this revision.Oct 22 2018, 7:56 AM
Herald added subscribers: llvm-commits, tschuett. · View Herald TranscriptOct 22 2018, 7:56 AM
Harbormaster completed remote builds in B23994: Diff 170414.Oct 22 2018, 7:56 AM
courbet accepted this revision.Oct 22 2018, 7:57 AM
This revision is now accepted and ready to land.Oct 22 2018, 7:57 AM
Closed by commit rL344906: [llvm-exegesis] Mark x86 segment register instructions as unsupported. (authored by gchatelet). · Explain WhyOct 22 2018, 7:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
llvm-exegesis/
lib/
X86/
6 lines

Diff 170414

tools/llvm-exegesis/lib/X86/Target.cpp

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines if (!ValidMemoryOperands)
return llvm::make_error<BenchmarkFailure>( return llvm::make_error<BenchmarkFailure>(
"unsupported opcode: non uniform memory access"); "unsupported opcode: non uniform memory access");
// We do not handle instructions with OPERAND_PCREL. // We do not handle instructions with OPERAND_PCREL.
for (const Operand &Op : Instr.Operands) for (const Operand &Op : Instr.Operands)
if (Op.isExplicit() && if (Op.isExplicit() &&
Op.getExplicitOperandInfo().OperandType == llvm::MCOI::OPERAND_PCREL) Op.getExplicitOperandInfo().OperandType == llvm::MCOI::OPERAND_PCREL)
return llvm::make_error<BenchmarkFailure>( return llvm::make_error<BenchmarkFailure>(
"unsupported opcode: PC relative operand"); "unsupported opcode: PC relative operand");
for (const Operand &Op : Instr.Operands)
if (Op.isReg() && Op.isExplicit() &&
Op.getExplicitOperandInfo().RegClass ==
llvm::X86::SEGMENT_REGRegClassID)
return llvm::make_error<BenchmarkFailure>(
"unsupported opcode: access segment memory");
// We do not handle second-form X87 instructions. We only handle first-form // We do not handle second-form X87 instructions. We only handle first-form
// ones (_Fp), see comment in X86InstrFPStack.td. // ones (_Fp), see comment in X86InstrFPStack.td.
for (const Operand &Op : Instr.Operands) for (const Operand &Op : Instr.Operands)
if (Op.isReg() && Op.isExplicit() && if (Op.isReg() && Op.isExplicit() &&
Op.getExplicitOperandInfo().RegClass == llvm::X86::RSTRegClassID) Op.getExplicitOperandInfo().RegClass == llvm::X86::RSTRegClassID)
return llvm::make_error<BenchmarkFailure>( return llvm::make_error<BenchmarkFailure>(
"unsupported second-form X87 instruction"); "unsupported second-form X87 instruction");
return llvm::Error::success(); return llvm::Error::success();
▲ Show 20 Lines • Show All 320 Lines • Show Last 20 Lines