[Windows] Fix threads comparison on Windows

[aleksandr.urakov]

Summary

This patch makes Windows threads to compare by a thread ID, not by a handle. It's because the same thread can have different handles on Windows (for example, GetCurrentThread always returns the fake handle -2). This leads to some incorrect behavior. For example, in Process::GetRunLock always m_public_run_lock is returned without this patch.

[stella.stamenova]

LGTM

[aleksandr.urakov]

Thank you!

lldb/trunk/include/lldb/Host/HostNativeThreadBase.h

public:
   HostNativeThreadBase();
   explicit HostNativeThreadBase(lldb::thread_t thread);
   virtual ~HostNativeThreadBase() {}
 
   virtual Status Join(lldb::thread_result_t *result) = 0;
   virtual Status Cancel() = 0;
   virtual bool IsJoinable() const;
   virtual void Reset();
+  virtual bool EqualsThread(lldb::thread_t thread) const;
   lldb::thread_t Release();
 
   lldb::thread_t GetSystemHandle() const;
   lldb::thread_result_t GetResult() const;
 
 protected:
   static lldb::thread_result_t THREAD_ROUTINE
   ThreadCreateTrampoline(lldb::thread_arg_t arg);
 
   lldb::thread_t m_thread;
   lldb::thread_result_t m_result;
 };
 }
 
 #endif

lldb/trunk/include/lldb/Host/windows/HostThreadWindows.h

public:
   HostThreadWindows(lldb::thread_t thread);
   virtual ~HostThreadWindows();
 
   void SetOwnsHandle(bool owns);
 
   virtual Status Join(lldb::thread_result_t *result);
   virtual Status Cancel();
   virtual void Reset();
+  virtual bool EqualsThread(lldb::thread_t thread) const;
 
   lldb::tid_t GetThreadId() const;
 
 private:
   bool m_owns_handle;
 };
 }
 
 #endif

lldb/trunk/source/Host/common/HostNativeThreadBase.cpp

bool HostNativeThreadBase::IsJoinable() const {
   return m_thread != LLDB_INVALID_HOST_THREAD;
 }
 
 void HostNativeThreadBase::Reset() {
   m_thread = LLDB_INVALID_HOST_THREAD;
   m_result = 0;
 }
 
+bool HostNativeThreadBase::EqualsThread(lldb::thread_t thread) const {
+  return m_thread == thread;
+}
+
 lldb::thread_t HostNativeThreadBase::Release() {
   lldb::thread_t result = m_thread;
   m_thread = LLDB_INVALID_HOST_THREAD;
   m_result = 0;
 
   return result;
 }
 

lldb/trunk/source/Host/common/HostThread.cpp

const HostNativeThread &HostThread::GetNativeThread() const {
   return static_cast<const HostNativeThread &>(*m_native_thread);
 }
 
 lldb::thread_result_t HostThread::GetResult() const {
   return m_native_thread->GetResult();
 }
 
 bool HostThread::EqualsThread(lldb::thread_t thread) const {
-  return m_native_thread->GetSystemHandle() == thread;
+  return m_native_thread->EqualsThread(thread);
 }

lldb/trunk/source/Host/windows/HostThreadWindows.cpp

 }
 
 void HostThreadWindows::Reset() {
   if (m_owns_handle && m_thread != LLDB_INVALID_HOST_THREAD)
     ::CloseHandle(m_thread);
 
   HostNativeThreadBase::Reset();
 }
+
+bool HostThreadWindows::EqualsThread(lldb::thread_t thread) const {
+  return GetThreadId() == ::GetThreadId(thread);
+}