Page MenuHomePhabricator

[lldbsuite] Make the names of test classes unique
ClosedPublic

Authored by stella.stamenova on Oct 15 2018, 12:03 PM.

Details

Summary

If the names are not unique, the tests overwrite each other's results and logs. This also causes failures on platforms where the files are locked for writing.

The names of the class/test pairs *have to* always be unique. The easiest way to achieve that is to name each class differently (usually the same as the file name).

Diff Detail

Repository
rLLDB LLDB

Event Timeline

It would be great if we can detect this when all of the test files are loaded and emit an error instead of waiting for results to be overwritten

This revision was not accepted when it landed; it landed in state Needs Review.Oct 15 2018, 12:53 PM
This revision was automatically updated to reflect the committed changes.