This is an archive of the discontinued LLVM Phabricator instance.

Differential D53114

[libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl,-dead_strip.
ClosedPublic

Authored by Dor1s on Oct 10 2018, 3:46 PM.

Details

Reviewers
morehouse
kcc
george.karpenkov
Commits
rG6cbb3ca456e3: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl…
rL344346: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl…
rCRT344346: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl…
Summary

The corresponding asncov change: https://reviews.llvm.org/D53113.

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=892167

Diff Detail

Event Timeline

Dor1s created this revision.Oct 10 2018, 3:46 PM
Harbormaster completed remote builds in B23676: Diff 169118.Oct 10 2018, 3:46 PM
Herald added subscribers: Restricted Project, delcypher. · View Herald TranscriptOct 10 2018, 3:46 PM
george.karpenkov added a parent revision: D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..Oct 10 2018, 3:51 PM
morehouse accepted this revision.Oct 10 2018, 3:52 PM
This revision is now accepted and ready to land.Oct 10 2018, 3:52 PM
george.karpenkov accepted this revision.Oct 10 2018, 3:53 PM
Closed by commit rCRT344346: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl… (authored by Dor1s). · Explain WhyOct 12 2018, 7:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
fuzzer/
23 lines

Diff 169393

test/fuzzer/dead-stripping.test

REQUIRES: darwin
No dead_strip. Unused code is not removed.
RUN: %cpp_compiler %S/GcSectionsTest.cpp -o %t
RUN: nm %t | grep UnusedFunctionShouldBeRemovedByLinker | count 1
RUN: %run %t -runs=0 2>&1 | FileCheck %s
With dead_strip. Unused code is not removed.
RUN: %cpp_compiler %S/GcSectionsTest.cpp -o %t -ffunction-sections -Wl,-dead_strip
RUN: nm %t | grep UnusedFunctionShouldBeRemovedByLinker | count 1
RUN: %run %t -runs=0 2>&1 | FileCheck %s
With dead_strip, with trace-pc. Unused code is removed.
RUN: %cpp_compiler %S/GcSectionsTest.cpp -o %t -ffunction-sections -fsanitize-coverage=0 -fsanitize-coverage=trace-pc -Wl,-dead_strip
RUN: nm %t | not grep UnusedFunctionShouldBeRemovedByLinker
RUN: %run %t -runs=0 2>&1 | FileCheck %s
With dead_strip, with pc-table. Unused code is not removed.
RUN: %cpp_compiler %S/GcSectionsTest.cpp -o %t -ffunction-sections -fsanitize-coverage=0 -fsanitize-coverage=trace-pc-guard,pc-table -Wl,-dead_strip
RUN: nm %t | grep UnusedFunctionShouldBeRemovedByLinker | count 1
RUN: %run %t -runs=0 2>&1 | FileCheck %s
CHECK-NOT: ERROR: The size of coverage PC tables does not match