Page MenuHomePhabricator

[lldb] Add support in Status::AsCString to retrieve win32 system error strings
ClosedPublic

Authored by asmith on Oct 10 2018, 10:18 AM.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

asmith created this revision.Oct 10 2018, 10:18 AM

Otherwise LGTM!

unittests/Utility/StatusTest.cpp
68–74

I'm not sure, can we rely on the fact that messages are the same in different versions of Windows?

asmith added inline comments.Oct 19 2018, 11:52 AM
unittests/Utility/StatusTest.cpp
68–74

I don't think the errors are different but I don't have old versions of Windows setup to test. Everyone should be on Win10 right :-) I'll keep an eye on the buildbots after I commit.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 19 2018, 12:00 PM
This revision was automatically updated to reflect the committed changes.