[LLDB] Force message formatting to English

[aganea]

Summary

This is a follow-up on D53092, and fixes the test below on non-English locales (below, on a French locale):

[ RUN      ] StatusTest.ErrorWin32
F:\llvm-project\lldb\unittests\Utility\StatusTest.cpp(67): error:       Expected: "Access is denied. "
To be equal to: s.AsCString()
      Which is: "Acc\xE8s refus\xE9. "
F:\llvm-project\lldb\unittests\Utility\StatusTest.cpp(70): error:       Expected: "Negotiation timed out "
To be equal to: s.AsCString()
      Which is: "Le d\xE9lai d\x92" "attente a expir\xE9 pour la n\xE9gociation "
[  FAILED  ] StatusTest.ErrorWin32 (2 ms)

[rnk]

lgtm

lldb/source/Utility/Status.cpp

 
 Status::~Status() = default;
 
 #ifdef _WIN32
 static std::string RetrieveWin32ErrorString(uint32_t error_code) {
   char *buffer = nullptr;
   std::string message;
   // Retrieve win32 system error.
+  // First, attempt to load a en-US message
   if (::FormatMessageA(
           FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM |
               FORMAT_MESSAGE_MAX_WIDTH_MASK,
-          NULL, error_code, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
+          NULL, error_code, MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US),
           (LPSTR)&buffer, 0, NULL)) {
     message.assign(buffer);
     ::LocalFree(buffer);
   }
+  // If the previous didn't work, use the default OS language
+  else if (::FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER |
+                                FORMAT_MESSAGE_FROM_SYSTEM |
+                                FORMAT_MESSAGE_MAX_WIDTH_MASK,
+                            NULL, error_code, 0, (LPSTR)&buffer, 0, NULL)) {
+    message.assign(buffer);
+    ::LocalFree(buffer);
+  }
   return message;
 }
 #endif
 
 // Get the error value as a NULL C string. The error string will be fetched and
 // cached on demand. The cached error string value will remain until the error
 // value is changed or cleared.
 const char *Status::AsCString(const char *default_error_str) const {