Page MenuHomePhabricator

[LV] Ignore more debug info.
ClosedPublic

Authored by fhahn on Oct 10 2018, 10:15 AM.

Details

Summary

We can avoid doing some unnecessary work by skipping debug instructions
in a few loops. It also helps to ensure debug instructions do not
prevent vectorization, although I do not have any concrete test cases
for that.

Diff Detail

Repository
rL LLVM

Event Timeline

fhahn created this revision.Oct 10 2018, 10:15 AM
rengolin accepted this revision.Oct 10 2018, 10:21 AM

Seems trivial. instructionsWithoutDebug is just an iterator filter and there are no early continues in the body of the outer loop, so this actually saves time.

I'm not sure there is any case where a debug info would stop vectorisation, but this is a good change regardless.

LGTM, thanks!

This revision is now accepted and ready to land.Oct 10 2018, 10:21 AM
Closed by commit rL344232: [LV] Ignore more debug info. (authored by fhahn, committed by ). · Explain WhyOct 11 2018, 2:30 AM
This revision was automatically updated to reflect the committed changes.