This is an archive of the discontinued LLVM Phabricator instance.

[libcxxabi] Allow building with sanitizers enabled
ClosedPublic

Authored by ldionne on Oct 9 2018, 10:20 AM.

Details

Summary

I copied the sanitizer-related logic in libcxx/lib/CMakeLists.txt. In
the future, it would be great to avoid duplicating this logic in the
compiler, libc++ and libc++abi.

Diff Detail

Repository
rCXXA libc++abi

Event Timeline

ldionne created this revision.Oct 9 2018, 10:20 AM

Other than above, this looks fine to me - but I haven't done much to the CMake stuff. Waiting for @EricWF to take a look.

libcxxabi/src/CMakeLists.txt
116 ↗(On Diff #168826)

Is this just a Mac OS X feature, then?

EricWF accepted this revision.Oct 10 2018, 11:42 AM

@ldionne This looks fine to me, but I don't love the duplication.

I think this patch gives yet another reason why libc++ and libc++abi should live in the same repo.

libcxxabi/src/CMakeLists.txt
116 ↗(On Diff #168826)

We only need this configuration on Mac OS X because the Clang driver on other platforms links these libraries for us.

This revision is now accepted and ready to land.Oct 10 2018, 11:42 AM
ldionne added inline comments.Oct 10 2018, 3:01 PM
libcxxabi/src/CMakeLists.txt
116 ↗(On Diff #168826)

Is this not a Clang bug, then?

This revision was automatically updated to reflect the committed changes.