[WebAssembly] Don't modify preds/succs iterators while erasing from them

[aheejin]

Summary

This caused out-of-bound bugs. Found by
-DLLVM_ENABLE_EXPENSIVE_CHECKS=ON.

[dschuff]

lib/Target/WebAssembly/WebAssemblyLateEHPrepare.cpp

94 ↗

(On Diff #168349)

Could you just copy the Predecessors in the constructor, the way you do with WL?

[dschuff]

Otherwise LGTM, and I verified that it fixes the expensive checks failure.

lib/Target/WebAssembly/WebAssemblyLateEHPrepare.cpp

94 ↗

(On Diff #168349)

e.g. Preds(MBB->pred_begin(), MBB->pred_end())

[aheejin]

• Use iterators within constructors / append

llvm/trunk/lib/Target/WebAssembly/WebAssemblyLateEHPrepare.cpp

 // Erases the given BBs and all their children from the function. If other BBs
 // have the BB as a successor, the successor relationships will be deleted as
 // well.
 template <typename Container>
 static void EraseBBsAndChildren(const Container &MBBs) {
   SmallVector<MachineBasicBlock *, 8> WL(MBBs.begin(), MBBs.end());
   while (!WL.empty()) {
     MachineBasicBlock *MBB = WL.pop_back_val();
-    for (auto *Pred : MBB->predecessors())
+    SmallVector<MachineBasicBlock *, 4> Preds(MBB->pred_begin(),
+                                              MBB->pred_end());
+    for (auto *Pred : Preds)
       Pred->removeSuccessor(MBB);
-    for (auto *Succ : MBB->successors()) {
-      WL.push_back(Succ);
+    SmallVector<MachineBasicBlock *, 4> Succs(MBB->succ_begin(),
+                                              MBB->succ_end());
+    WL.append(MBB->succ_begin(), MBB->succ_end());
+    for (auto *Succ : Succs)
       MBB->removeSuccessor(Succ);
-    }
     MBB->eraseFromParent();
   }
 }
 
 bool WebAssemblyLateEHPrepare::runOnMachineFunction(MachineFunction &MF) {
   if (MF.getTarget().getMCAsmInfo()->getExceptionHandlingType() !=
       ExceptionHandling::Wasm)
     return false;