This is an archive of the discontinued LLVM Phabricator instance.

Differential D52870

[NestedNameSpecifier] Add missing stream-specific dump methods
ClosedPublic

Authored by steveire on Oct 4 2018, 1:51 AM.

Details

Reviewers
aaron.ballman
Commits
rG07dd5af6dfae: [NestedNameSpecifier] Add missing stream-specific dump methods
rC343807: [NestedNameSpecifier] Add missing stream-specific dump methods
rL343807: [NestedNameSpecifier] Add missing stream-specific dump methods

Diff Detail

Event Timeline

steveire created this revision.Oct 4 2018, 1:51 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptOct 4 2018, 1:51 AM
Harbormaster completed remote builds in B23442: Diff 168241.Oct 4 2018, 1:51 AM
aaron.ballman added inline comments.Oct 4 2018, 11:12 AM
lib/AST/NestedNameSpecifier.cpp
342

LLVM_DUMP_METHOD ?

346

LLVM_DUMP_METHOD ?

350

LLVM_DUMP_METHOD ?

351

Formatting is incorrect here.

356–357

Same here.

steveire updated this revision to Diff 168338.Oct 4 2018, 11:30 AM

Format

Harbormaster completed remote builds in B23468: Diff 168338.Oct 4 2018, 11:30 AM
steveire marked 5 inline comments as done.Oct 4 2018, 11:31 AM
aaron.ballman accepted this revision.Oct 4 2018, 12:20 PM

LGTM!

This revision is now accepted and ready to land.Oct 4 2018, 12:20 PM
Closed by commit rL343807: [NestedNameSpecifier] Add missing stream-specific dump methods (authored by steveire). · Explain WhyOct 4 2018, 12:24 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptOct 4 2018, 12:24 PM

Revision Contents

PathSize
include/
clang/
AST/
2 lines
lib/
AST/
16 lines

Diff 168241

include/clang/AST/NestedNameSpecifier.h

Show First 20 Lines • Show All 219 Lines • ▼ Show 20 Lines void Profile(llvm::FoldingSetNodeID &ID) const {
ID.AddPointer(Prefix.getOpaqueValue()); ID.AddPointer(Prefix.getOpaqueValue());
ID.AddPointer(Specifier); ID.AddPointer(Specifier);
} }
/// Dump the nested name specifier to standard output to aid /// Dump the nested name specifier to standard output to aid
/// in debugging. /// in debugging.
void dump(const LangOptions &LO) const; void dump(const LangOptions &LO) const;
void dump() const; void dump() const;
void dump(llvm::raw_ostream& OS) const;
void dump(llvm::raw_ostream& OS, const LangOptions &LO) const;
}; };
/// A C++ nested-name-specifier augmented with source location /// A C++ nested-name-specifier augmented with source location
/// information. /// information.
class NestedNameSpecifierLoc { class NestedNameSpecifierLoc {
NestedNameSpecifier *Qualifier = nullptr; NestedNameSpecifier *Qualifier = nullptr;
void *Data = nullptr; void *Data = nullptr;
▲ Show 20 Lines • Show All 285 Lines • Show Last 20 Lines

lib/AST/NestedNameSpecifier.cpp

Show First 20 Lines • Show All 333 Lines • ▼ Show 20 Lines case TypeSpec: {
} }
break; break;
} }
} }
OS << "::"; OS << "::";
} }
void NestedNameSpecifier::dump(const LangOptions &LO) const { void NestedNameSpecifier::dump(const LangOptions &LO) const {
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

LLVM_DUMP_METHOD ?

aaron.ballman: `LLVM_DUMP_METHOD` ?
print(llvm::errs(), PrintingPolicy(LO)); dump(llvm::errs(), LO);
} }
LLVM_DUMP_METHOD void NestedNameSpecifier::dump() const { void NestedNameSpecifier::dump() const {
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

LLVM_DUMP_METHOD ?

aaron.ballman: `LLVM_DUMP_METHOD` ?
dump(llvm::errs());
}
void NestedNameSpecifier::dump(llvm::raw_ostream& OS) const
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

LLVM_DUMP_METHOD ?

aaron.ballman: `LLVM_DUMP_METHOD` ?
{
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

Formatting is incorrect here.

aaron.ballman: Formatting is incorrect here.
LangOptions LO; LangOptions LO;
print(llvm::errs(), PrintingPolicy(LO)); dump(OS, LO);
}
LLVM_DUMP_METHOD void NestedNameSpecifier::dump(llvm::raw_ostream& OS, const LangOptions &LO) const
{
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

Same here.

aaron.ballman: Same here.
print(OS, PrintingPolicy(LO));
} }
unsigned unsigned
NestedNameSpecifierLoc::getLocalDataLength(NestedNameSpecifier *Qualifier) { NestedNameSpecifierLoc::getLocalDataLength(NestedNameSpecifier *Qualifier) {
assert(Qualifier && "Expected a non-NULL qualifier"); assert(Qualifier && "Expected a non-NULL qualifier");
// Location of the trailing '::'. // Location of the trailing '::'.
unsigned Length = sizeof(unsigned); unsigned Length = sizeof(unsigned);
▲ Show 20 Lines • Show All 344 Lines • Show Last 20 Lines