[NestedNameSpecifier] Add missing stream-specific dump methods

[aaron.ballman]

lib/AST/NestedNameSpecifier.cpp

342 ↗

(On Diff #168241)

LLVM_DUMP_METHOD ?

346 ↗

(On Diff #168241)

LLVM_DUMP_METHOD ?

350 ↗

(On Diff #168241)

LLVM_DUMP_METHOD ?

351 ↗

(On Diff #168241)

Formatting is incorrect here.

356–357 ↗

(On Diff #168241)

Same here.

[steveire]

Format

[aaron.ballman]

LGTM!

cfe/trunk/include/clang/AST/NestedNameSpecifier.h

void Profile(llvm::FoldingSetNodeID &ID) const {
     ID.AddPointer(Prefix.getOpaqueValue());
     ID.AddPointer(Specifier);
   }
 
   /// Dump the nested name specifier to standard output to aid
   /// in debugging.
   void dump(const LangOptions &LO) const;
   void dump() const;
+  void dump(llvm::raw_ostream &OS) const;
+  void dump(llvm::raw_ostream &OS, const LangOptions &LO) const;
 };
 
 /// A C++ nested-name-specifier augmented with source location
 /// information.
 class NestedNameSpecifierLoc {
   NestedNameSpecifier *Qualifier = nullptr;
   void *Data = nullptr;
 

cfe/trunk/lib/AST/NestedNameSpecifier.cpp

case TypeSpec: {
     }
     break;
   }
   }
 
   OS << "::";
 }
 
-void NestedNameSpecifier::dump(const LangOptions &LO) const {
-  print(llvm::errs(), PrintingPolicy(LO));
+LLVM_DUMP_METHOD void NestedNameSpecifier::dump(const LangOptions &LO) const {
+  dump(llvm::errs(), LO);
 }
 
-LLVM_DUMP_METHOD void NestedNameSpecifier::dump() const {
+LLVM_DUMP_METHOD void NestedNameSpecifier::dump() const { dump(llvm::errs()); }
+
+LLVM_DUMP_METHOD void NestedNameSpecifier::dump(llvm::raw_ostream &OS) const {
   LangOptions LO;
-  print(llvm::errs(), PrintingPolicy(LO));
+  dump(OS, LO);
+}
+
+LLVM_DUMP_METHOD void NestedNameSpecifier::dump(llvm::raw_ostream &OS,
+                                                const LangOptions &LO) const {
+  print(OS, PrintingPolicy(LO));
 }
 
 unsigned
 NestedNameSpecifierLoc::getLocalDataLength(NestedNameSpecifier *Qualifier) {
   assert(Qualifier && "Expected a non-NULL qualifier");
 
   // Location of the trailing '::'.
   unsigned Length = sizeof(unsigned);