Page MenuHomePhabricator

Support checking out cte to 'extra' only as backward compatibility
AbandonedPublic

Authored by steveire on Oct 3 2018, 12:50 AM.

Details

Reviewers
aaron.ballman
Summary

This requirement to check it out in a directory called 'extra' was never
documented for git users, so git users doing the obvious thing (just
clone, don't specify a name) will silently not get clang-tools-extra
built.

Even reading the code is confusing because the
add_llvm_external_project macro appears to be used in place of the
add_subdirectory command, though the latter treats the second
placement argument as just a build directory name. So, anyone assuming
the same semantic with add_llvm_external_project would be confused.

Diff Detail

Event Timeline

steveire created this revision.Oct 3 2018, 12:50 AM

Given the scope of what this changes (such as 3rd party configurations), I think that this requires a broader community discussion than what you'll get from this patch. I would suggest starting an [RFC] thread on cfe-commits and cfe-dev to see what people think of the idea.

Personally, I'm opposed to the idea. There is limited benefit compared to the number of scripts I will have to go update for out-of-tree builds where I'll suddenly be getting cmake warnings about a directory name that I've used without issue for years. If anything, I think the logic should be reversed so that we warn users who try to use "clang-tools-extra" as the directory name rather than "extra".

steveire abandoned this revision.Oct 8 2018, 11:33 AM