Page MenuHomePhabricator

Change the warning message for -warn-ifunc-textrel.
AcceptedPublic

Authored by ruiu on Oct 2 2018, 4:28 PM.

Details

Summary

I don't think you can fix the issue by recompiling it without -fPIC
(is it?). This patch also change the man page description because that's
too detailed. Technical details of the glibc's bug should be noted in a
commit message, but that doesn't have to be written in a man page.

Event Timeline

ruiu created this revision.Oct 2 2018, 4:28 PM
emaste added a comment.Oct 2 2018, 5:12 PM

I don't think you can fix the issue by recompiling it without -fPIC

I would think a fix would be compiling with -fPIC.

lld/ELF/Relocations.cpp
991

I'm not sure about advice to link without -z text - that's the default, and so linking with or without it should have the same effect, disallowing text relocations?

ruiu updated this revision to Diff 168180.Oct 3 2018, 2:47 PM
  • update the warning message
emaste accepted this revision.Sep 3 2019, 11:05 AM
This revision is now accepted and ready to land.Sep 3 2019, 11:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2019, 11:05 AM
Herald added a subscriber: MaskRay. · View Herald Transcript
MaskRay added inline comments.Sep 10 2019, 3:04 AM
lld/ELF/Relocations.cpp
991

I wonder if this option is still needed...