This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Use just basename when copying C++ ABI headers
ClosedPublic

Authored by phosek on Oct 1 2018, 7:14 PM.

Diff Detail

Repository
rCXX libc++

Event Timeline

phosek created this revision.Oct 1 2018, 7:14 PM
mgorny added a comment.Oct 2 2018, 3:39 PM

Thanks. I can confirm that it fixes installing libsupc++ headers for us on the main ABI. Apparently the headers in 32-bit multilib build aren't installed but I see the same issue with libcxx-6.0.1, so it's not a regression (and probably a bug on our end).

Ping? Would it be possible to get an LGTM so I can land this?

ldionne accepted this revision.Oct 3 2018, 4:42 PM

Do we have an open-source tester that would have caught that? Do we build against libsupc++ on Green Dragon?

This revision is now accepted and ready to land.Oct 3 2018, 4:42 PM
This revision was automatically updated to reflect the committed changes.