This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Include inlined frames into __sanitizer_symbolize_pc output
ClosedPublic

Authored by vitalybuka on Oct 1 2018, 1:25 PM.

Diff Detail

Event Timeline

vitalybuka created this revision.Oct 1 2018, 1:25 PM
vitalybuka edited the summary of this revision. (Show Details)Oct 1 2018, 1:50 PM
vitalybuka updated this revision to Diff 167824.Oct 1 2018, 1:56 PM

documentation

eugenis added inline comments.Oct 1 2018, 2:56 PM
compiler-rt/include/sanitizer/common_interface_defs.h
127 ↗(On Diff #167826)

Mention that the frames are printed in the order from most-inlined to least-inlined.

129 ↗(On Diff #167826)

typo: inlined

compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_libcdep.cc
126

what does this condition do?

vitalybuka updated this revision to Diff 167844.Oct 1 2018, 3:39 PM

Updated doc

vitalybuka added inline comments.Oct 1 2018, 3:44 PM
compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_libcdep.cc
126

you can provide weird "fmt" which will result in empty strings.
Having that empty string is terminator we'd like to avoid them in the middle.

eugenis accepted this revision.Oct 1 2018, 3:50 PM

LGTM

This revision is now accepted and ready to land.Oct 1 2018, 3:50 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: Restricted Project. · View Herald TranscriptOct 1 2018, 5:31 PM