This is an archive of the discontinued LLVM Phabricator instance.

[analyzer][NFC] Refactor functions in PlistDiagnostics to take Preproc as parameter
ClosedPublic

Authored by Szelethus on Oct 1 2018, 10:36 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

Szelethus created this revision.Oct 1 2018, 10:36 AM
george.karpenkov requested changes to this revision.Oct 1 2018, 10:40 AM

Please reupload with context (-U999)

This revision now requires changes to proceed.Oct 1 2018, 10:40 AM
Szelethus updated this revision to Diff 167776.Oct 1 2018, 10:53 AM
Szelethus retitled this revision from [analyzer][NFC] Refactor functions in PlistDiDiagnostics to take Preproc as parameter to [analyzer][NFC] Refactor functions in PlistDiagnostics to take Preproc as parameter.

Oops.

george.karpenkov accepted this revision.Oct 1 2018, 10:55 AM
george.karpenkov added inline comments.
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
98 ↗(On Diff #167776)

+1 for identifying redundant arguments.

This revision is now accepted and ready to land.Oct 1 2018, 10:55 AM
Szelethus added a comment.EditedOct 1 2018, 10:59 AM

Would you be okay with me clang-formatting this file? I'm aware of a few people doing some work with it, but the diff didn't seem too bad to cause any serious rebasing nightmares.

Sorry no --- going through those while doing archaeology sucks.
You could reformat your changed lines though.

Ah, okay, I'm fine with that.

This revision was automatically updated to reflect the committed changes.