This is an archive of the discontinued LLVM Phabricator instance.

Introduce completionItemKind capability support.
ClosedPublic

Authored by kadircet on Sep 27 2018, 8:17 AM.

Diff Detail

Event Timeline

kadircet created this revision.Sep 27 2018, 8:17 AM
kadircet updated this revision to Diff 167332.Sep 27 2018, 8:27 AM
  • Minimum CompletionItemKind is Text.
sammccall accepted this revision.Sep 27 2018, 9:24 AM
sammccall added inline comments.
clangd/ClangdLSPServer.cpp
109

also check if valueSet is None before dereferencing it?

clangd/Protocol.h
265

(nit: drop blank line for consistency)

274

wasn't obvious why this is necessary vs the default...
Maybe add a comment // Discards unknown kinds (and to SymbolKind)?

This revision is now accepted and ready to land.Sep 27 2018, 9:24 AM
kadircet updated this revision to Diff 167346.Sep 27 2018, 10:08 AM
kadircet marked 3 inline comments as done.
  • Address comments.
This revision was automatically updated to reflect the committed changes.