Page MenuHomePhabricator

[lib/fuzzer] Fix logging for Fuchsia
ClosedPublic

Authored by aarongreen on Sep 26 2018, 10:32 AM.

Details

Summary

This change fixes two aspects of logging on Fuchsia:

  1. When logging to stdout, the output file descriptor should not be closed in ExecuteCommand, as it prevent fdio_spawn_etc from succeeding in subsequent calls.
  2. When logging to a file in anything other than standalone Zircon, the log file needs to be created in mutable storage. The best indicator where this is relative to the Fuchsia component will be given by '-artifact_prefix=...', so save the log file relative to that path.

Diff Detail

Repository
rL LLVM

Event Timeline

aarongreen created this revision.Sep 26 2018, 10:32 AM
Herald added subscribers: Restricted Project, llvm-commits. · View Herald TranscriptSep 26 2018, 10:32 AM
This revision is now accepted and ready to land.Sep 26 2018, 11:44 AM
This revision was automatically updated to reflect the committed changes.