This is an archive of the discontinued LLVM Phabricator instance.

Differential D52383

Fix codemodels.c test case (only test mcmodel-kernel on x86)
ClosedPublic

Authored by cmtice on Sep 21 2018, 4:03 PM.

Details

Reviewers
tejohnson
javed.absar
echristo
Commits
rG7fc64a69b623: Fix codemodels.c test case (only test mcmodel-kernel on x86)
rC342789: Fix codemodels.c test case (only test mcmodel-kernel on x86)
rL342789: Fix codemodels.c test case (only test mcmodel-kernel on x86)
Summary

A recent commit I made broke aarch64 testing, because "kernel" apparently is not a valid code-model on aarch64, and one of my tests tested that. This fixes the problem (hopefully) by adding "-triple x86_64-unknown-linux-gnu" to the test build with "-mcodel-model kernel".

Diff Detail

Repository
rL LLVM

Event Timeline

cmtice created this revision.Sep 21 2018, 4:03 PM
Herald added a reviewer: javed.absar. · View Herald TranscriptSep 21 2018, 4:03 PM
Herald added a subscriber: kristof.beyls. · View Herald Transcript
tejohnson accepted this revision.Sep 21 2018, 4:16 PM

LGTM

This revision is now accepted and ready to land.Sep 21 2018, 4:16 PM
echristo accepted this revision.Sep 21 2018, 4:19 PM
Closed by commit rL342789: Fix codemodels.c test case (only test mcmodel-kernel on x86) (authored by ctice). · Explain WhySep 21 2018, 4:21 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 21 2018, 4:21 PM

Revision Contents

PathSize
cfe/
trunk/
test/
CodeGen/
2 lines

Diff 166574

cfe/trunk/test/CodeGen/codemodels.c

// RUN: %clang_cc1 -emit-llvm %s -o - | FileCheck %s -check-prefix=CHECK-NOMODEL // RUN: %clang_cc1 -emit-llvm %s -o - | FileCheck %s -check-prefix=CHECK-NOMODEL
// RUN: %clang_cc1 -emit-llvm -mcode-model tiny %s -o - | FileCheck %s -check-prefix=CHECK-TINY // RUN: %clang_cc1 -emit-llvm -mcode-model tiny %s -o - | FileCheck %s -check-prefix=CHECK-TINY
// RUN: %clang_cc1 -emit-llvm -mcode-model small %s -o - | FileCheck %s -check-prefix=CHECK-SMALL // RUN: %clang_cc1 -emit-llvm -mcode-model small %s -o - | FileCheck %s -check-prefix=CHECK-SMALL
// RUN: %clang_cc1 -emit-llvm -mcode-model kernel %s -o - | FileCheck %s -check-prefix=CHECK-KERNEL // RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -mcode-model kernel %s -o - | FileCheck %s -check-prefix=CHECK-KERNEL
// RUN: %clang_cc1 -emit-llvm -mcode-model medium %s -o - | FileCheck %s -check-prefix=CHECK-MEDIUM // RUN: %clang_cc1 -emit-llvm -mcode-model medium %s -o - | FileCheck %s -check-prefix=CHECK-MEDIUM
// RUN: %clang_cc1 -emit-llvm -mcode-model large %s -o - | FileCheck %s -check-prefix=CHECK-LARGE // RUN: %clang_cc1 -emit-llvm -mcode-model large %s -o - | FileCheck %s -check-prefix=CHECK-LARGE
// CHECK-TINY: !llvm.module.flags = !{{{.*}}} // CHECK-TINY: !llvm.module.flags = !{{{.*}}}
// CHECK-TINY: !{{[0-9]+}} = !{i32 1, !"Code Model", i32 0} // CHECK-TINY: !{{[0-9]+}} = !{i32 1, !"Code Model", i32 0}
// CHECK-SMALL: !llvm.module.flags = !{{{.*}}} // CHECK-SMALL: !llvm.module.flags = !{{{.*}}}
// CHECK-SMALL: !{{[0-9]+}} = !{i32 1, !"Code Model", i32 1} // CHECK-SMALL: !{{[0-9]+}} = !{i32 1, !"Code Model", i32 1}
// CHECK-KERNEL: !llvm.module.flags = !{{{.*}}} // CHECK-KERNEL: !llvm.module.flags = !{{{.*}}}
// CHECK-KERNEL: !{{[0-9]+}} = !{i32 1, !"Code Model", i32 2} // CHECK-KERNEL: !{{[0-9]+}} = !{i32 1, !"Code Model", i32 2}
// CHECK-MEDIUM: !llvm.module.flags = !{{{.*}}} // CHECK-MEDIUM: !llvm.module.flags = !{{{.*}}}
// CHECK-MEDIUM: !{{[0-9]+}} = !{i32 1, !"Code Model", i32 3} // CHECK-MEDIUM: !{{[0-9]+}} = !{i32 1, !"Code Model", i32 3}
// CHECK-LARGE: !llvm.module.flags = !{{{.*}}} // CHECK-LARGE: !llvm.module.flags = !{{{.*}}}
// CHECK-LARGE: !{{[0-9]+}} = !{i32 1, !"Code Model", i32 4} // CHECK-LARGE: !{{[0-9]+}} = !{i32 1, !"Code Model", i32 4}
// CHECK-NOMODEL-NOT: Code Model // CHECK-NOMODEL-NOT: Code Model