Page MenuHomePhabricator

[Swig] Merge typemaps with same bodies
ClosedPublic

Authored by tatyana-krasnukha on Sep 21 2018, 1:07 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

jingham requested changes to this revision.Sep 21 2018, 6:50 PM
jingham added a subscriber: jingham.

This patch changes the SB API. We don't break binary compatibility with the SB API's, and especially not for something like GetInstructions/GetInstructionsWithFlavor, which are functions somebody out there is sure to be using. See:

https://lldb.llvm.org/SB-api-coding-rules.html

I didn't know you could list multiple signatures in one type map, that part is cool!

But we don't allow removing SB API's, so the part where you remove a function and replace it with a defaulted argument one or straight up remove an API can't go in as is. If you want to add a cleaner function, that's fine.

BTW, Sean isn't working on lldb anymore, so assigning him as a reviewer isn't going to do much good :-(

This revision now requires changes to proceed.Sep 21 2018, 6:50 PM
tatyana-krasnukha retitled this revision from [API][Swig] Overloaded functions for SBTarget to [Swig] Merge typemaps with same bodies.
tatyana-krasnukha edited the summary of this revision. (Show Details)
tatyana-krasnukha removed a reviewer: spyffe.

Thanks for the information I missed. Removed all changes of API and joined together more typemap implementations.

jingham accepted this revision.Sep 24 2018, 2:34 PM

Nice, thanks!

This revision is now accepted and ready to land.Sep 24 2018, 2:34 PM
This revision was automatically updated to reflect the committed changes.