This is an archive of the discontinued LLVM Phabricator instance.

Differential D52278

Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin.
ClosedPublic

Authored by vsapsai on Sep 19 2018, 2:06 PM.

Details

Reviewers
dberris
devnexen
Commits
rOLDT342676: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin.
rL342676: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin.
Summary

Test is failing because __xray_log_select_mode("xray-fdr") returns XRAY_MODE_NOT_FOUND. Disable until it is fixed.

rdar://problem/44578416

Diff Detail

Repository
rL LLVM

Event Timeline

vsapsai created this revision.Sep 19 2018, 2:06 PM
Herald added subscribers: dexonsmith, mgorny. · View Herald TranscriptSep 19 2018, 2:06 PM
vsapsai mentioned this in D51606: [XRay] Remove the deprecated __xray_log_init API.Sep 19 2018, 2:23 PM
dberris accepted this revision.Sep 19 2018, 4:56 PM

LGTM

This revision is now accepted and ready to land.Sep 19 2018, 4:56 PM
Closed by commit rL342676: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin. (authored by vsapsai). · Explain WhySep 20 2018, 11:45 AM
This revision was automatically updated to reflect the committed changes.
vsapsai added a comment.Sep 20 2018, 11:52 AM

Thanks for review.

Revision Contents

PathSize
test-suite/
trunk/
MicroBenchmarks/
XRay/
8 lines

Diff 166339

test-suite/trunk/MicroBenchmarks/XRay/CMakeLists.txt

add_subdirectory(ReturnReference) add_subdirectory(ReturnReference)
if(NOT TARGET_OS STREQUAL "Darwin")
# FDRMode test is failing on Darwin because
# `__xray_log_select_mode("xray-fdr")` returns `XRAY_MODE_NOT_FOUND`.
#
# Disable the test until it is fixed. rdar://problem/44578416
add_subdirectory(FDRMode) add_subdirectory(FDRMode)
endif()