Page MenuHomePhabricator

[RegAllocGreedy] Fix crash in tryLocalSplit
ClosedPublic

Authored by waltl on Sep 19 2018, 12:33 PM.

Details

Summary

tryLocalSplit only handles a single use block, but an interval may have multiple use blocks. So don't crash in that case. This fixes PR38795.

Diff Detail

Repository
rL LLVM

Event Timeline

niravd created this revision.Sep 19 2018, 12:33 PM
waltl commandeered this revision.Sep 20 2018, 11:18 AM
waltl added a reviewer: niravd.
waltl updated this revision to Diff 166346.Sep 20 2018, 12:35 PM

Simplify fix; bugpoint test case.

waltl retitled this revision from [RegAlloc] Fix check for local splitting. to [RegAllocGreedy] Fix crash in tryLocalSplit.Sep 20 2018, 12:36 PM
waltl edited the summary of this revision. (Show Details)
niravd accepted this revision.Sep 20 2018, 12:49 PM

LGTM

This revision is now accepted and ready to land.Sep 20 2018, 12:49 PM
waltl updated this revision to Diff 166349.Sep 20 2018, 12:50 PM
waltl edited the summary of this revision. (Show Details)

Typo.

This revision was automatically updated to reflect the committed changes.