This is an archive of the discontinued LLVM Phabricator instance.

Deduplicate replacements from diagnostics.
ClosedPublic

Authored by ioeric on Sep 19 2018, 6:11 AM.

Details

Summary

After r329813, clang-apply-replacements stopped deduplicating identical
replacements; however, tools like clang-tidy relies on the deduplication of
identical dignostics replacements from different TUs to apply fixes correctly.

This change partially roll back the behavior by deduplicating changes from
diagnostics. Ideally, we should deduplicate on diagnostics level, but we need to
figure out an effecient way.

Diff Detail

Repository
rL LLVM

Event Timeline

ioeric created this revision.Sep 19 2018, 6:11 AM
This revision is now accepted and ready to land.Sep 24 2018, 2:06 PM
This revision was automatically updated to reflect the committed changes.
ioeric added a subscriber: bkramer.Sep 25 2018, 2:38 AM

I wasn't aware of the bug. I have just replied to the issue. Thanks for
letting me know!