This is an archive of the discontinued LLVM Phabricator instance.

[lldb-mi] Correct regex in the symbol-list-lines test
ClosedPublic

Authored by apolyakov on Sep 14 2018, 9:02 AM.

Download Raw Diff

Details

Reviewers

tatyana-krasnukha
aprantl
clayborg

Commits

rG164155659348: [lldb-mi] Correct regex in the symbol-list-lines test
rLLDB342329: [lldb-mi] Correct regex in the symbol-list-lines test
rL342329: [lldb-mi] Correct regex in the symbol-list-lines test

Summary

The test failed in case of compiling a test suite with
gcc (checked versions are 5.2.0 and 7.3.0) because it
adds one more line entry comparing to clang. It doesn't
break the test's logic, so I just added a regex that matches
this case.

Diff Detail

Repository: rL LLVM

Event Timeline

apolyakov created this revision.Sep 14 2018, 9:02 AM

Herald added a subscriber: ki.stfu. · View Herald TranscriptSep 14 2018, 9:02 AM

I've created this revision to be sure that you don't think that this approach is some kind of hack.

Thanks, that looks like a safe change.

This revision is now accepted and ready to land.Sep 14 2018, 12:34 PM

Closed by commit rL342329: [lldb-mi] Correct regex in the symbol-list-lines test (authored by apolyakov). · Explain WhySep 15 2018, 10:08 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 15 2018, 10:08 AM

Revision Contents

Path

Size

lldb/

trunk/

lit/

tools/

lldb-mi/

symbol/

symbol-list-lines.test

4 lines

Diff 165647

lldb/trunk/lit/tools/lldb-mi/symbol/symbol-list-lines.test

	# XFAIL: windows			# XFAIL: windows
	# -> llvm.org/pr24452			# -> llvm.org/pr24452
	#			#
	# RUN: %cc -o %t %p/inputs/main.c %p/inputs/symbol-list-lines.c %p/inputs/list-lines-helper.c -g			# RUN: %cc -o %t %p/inputs/main.c %p/inputs/symbol-list-lines.c %p/inputs/list-lines-helper.c -g
	# RUN: %lldbmi %t < %s \| FileCheck %s			# RUN: %lldbmi %t < %s \| FileCheck %s

	# Test lldb-mi -symbol-list-lines command.			# Test lldb-mi -symbol-list-lines command.

	# Check that we have a valid target created via '%lldbmi %t'.			# Check that we have a valid target created via '%lldbmi %t'.
	# CHECK: ^done			# CHECK: ^done

	-symbol-list-lines invalid_file.c			-symbol-list-lines invalid_file.c
	# Check a case of invalid file name.			# Check a case of invalid file name.
	# CHECK: ^error,msg="File Handler. Invalid file name path"			# CHECK: ^error,msg="File Handler. Invalid file name path"

	-symbol-list-lines symbol-list-lines.c			-symbol-list-lines symbol-list-lines.c
	# CHECK: ^done,lines=[{pc="0x{{[0-9A-Fa-f]+}}",line="3"},{pc="0x{{[0-9A-Fa-f]+}}",line="4"},{pc="0x{{[0-9A-Fa-f]+}}",line="5"}]			# CHECK: ^done,lines=[{pc="0x{{[0-9A-Fa-f]+}}",line="3"},{pc="0x{{[0-9A-Fa-f]+}}",line="4"},{pc="0x{{[0-9A-Fa-f]+}}",line="5"}{{.*}}]

	-symbol-list-lines list-lines-helper.c			-symbol-list-lines list-lines-helper.c
	# CHECK: ^done,lines=[{pc="0x{{[0-9A-Fa-f]+}}",line="1"},{pc="0x{{[0-9A-Fa-f]+}}",line="2"},{pc="0x{{[0-9A-Fa-f]+}}",line="3"}]			# CHECK: ^done,lines=[{pc="0x{{[0-9A-Fa-f]+}}",line="1"},{pc="0x{{[0-9A-Fa-f]+}}",line="2"},{pc="0x{{[0-9A-Fa-f]+}}",line="3"}{{.*}}]