apolyakov (Alexander Polyakov)
User

Projects

User does not belong to any projects.

User Details

User Since
Thu, Jun 7, 12:06 PM (1 w, 3 d)

Recent Activity

Fri, Jun 15

apolyakov added a comment to D47992: [lldb-mi] Correct error processing in exec-next command..

If you look at bool CMICmdCmdExecContinue::Execute(), you'll see that there are cases in which we need a flexible way to finish MI command(specific action in error case for example). We have a few options: not to add such an utility function, add and use it in simple situations where we just want to check on SBError status or we may create utility function with lambda functions in which user could specify actions he needs. What are your thoughts about this?

Fri, Jun 15, 1:48 PM
apolyakov committed rL334860: Revert "[lldb-mi] Add overload method for setting an error".
Revert "[lldb-mi] Add overload method for setting an error"
Fri, Jun 15, 1:25 PM
apolyakov closed D48212: Revert "[lldb-mi] Add overload method for setting an error".
Fri, Jun 15, 1:25 PM
apolyakov updated the summary of D48212: Revert "[lldb-mi] Add overload method for setting an error".
Fri, Jun 15, 3:27 AM
apolyakov updated subscribers of D48212: Revert "[lldb-mi] Add overload method for setting an error".
Fri, Jun 15, 3:20 AM
apolyakov created D48212: Revert "[lldb-mi] Add overload method for setting an error".
Fri, Jun 15, 3:20 AM

Wed, Jun 13

apolyakov added a comment to D47991: Improve SBThread's stepping API using SBError parameter..

Looks good. Just a question about including the commented out default arguments

Wed, Jun 13, 8:47 AM

Tue, Jun 12

apolyakov updated the diff for D47991: Improve SBThread's stepping API using SBError parameter..

Minor update: moved error.SetErrorString to the top of if statement to increase readability.

Tue, Jun 12, 12:50 PM
apolyakov added inline comments to D47991: Improve SBThread's stepping API using SBError parameter..
Tue, Jun 12, 12:42 PM
apolyakov updated the diff for D47991: Improve SBThread's stepping API using SBError parameter..

Added StepOver overload without optional parameters.

Tue, Jun 12, 12:41 PM
apolyakov added inline comments to D47991: Improve SBThread's stepping API using SBError parameter..
Tue, Jun 12, 11:16 AM
apolyakov updated the diff for D47991: Improve SBThread's stepping API using SBError parameter..

Added early exits.

Tue, Jun 12, 11:13 AM
apolyakov updated the diff for D47991: Improve SBThread's stepping API using SBError parameter..

Some readability improvements(more comments). I think that we should keep StepOver signature as

void StepOver(SBError &error, lldb::RunMode stop_other_threads);

since it seems that in SBThread methods SBError paramater is the last non-optional one, as @aprantl said.

Tue, Jun 12, 3:06 AM

Mon, Jun 11

apolyakov added a comment to D47991: Improve SBThread's stepping API using SBError parameter..

By the way, we can do something like:

void StepOver() {
  StepOver(lldb:eOnlyDuringStepping);
}
Mon, Jun 11, 2:41 PM
apolyakov added a comment to D47991: Improve SBThread's stepping API using SBError parameter..

Have you looked into making the error the first vs the last argument? If the majority of all SBAPI calls put the error last, we should do this here, too.

Mon, Jun 11, 2:02 PM
apolyakov updated the diff for D47991: Improve SBThread's stepping API using SBError parameter..

Documented changes and overloaded all stepping functions.

Mon, Jun 11, 12:38 PM
apolyakov added a comment to D47991: Improve SBThread's stepping API using SBError parameter..

Hmm.. it looks like most C++ API calls don't have any documentation.

http://lldb.llvm.org/cpp_reference/html/classlldb_1_1SBThread.html#a42755a170e127881a5dd65162217f68b

It does look like the python API has more documentation.. where does that come from?

scripts/interface/SBThread.i

Mon, Jun 11, 10:21 AM
apolyakov added a comment to D47991: Improve SBThread's stepping API using SBError parameter..

I found it out. Info about each method is located in header file. For example, you may look at include/lldb/API/SBThread.h and find text from docs.

Mon, Jun 11, 9:58 AM
apolyakov added inline comments to D47991: Improve SBThread's stepping API using SBError parameter..
Mon, Jun 11, 9:31 AM

Sun, Jun 10

apolyakov committed rL334364: [lldb-mi] Re-implement MI -exec-step command..
[lldb-mi] Re-implement MI -exec-step command.
Sun, Jun 10, 8:03 AM
apolyakov closed D47838: [lldb-mi] Re-implement MI -exec-step command..
Sun, Jun 10, 8:02 AM
apolyakov added a comment to D47992: [lldb-mi] Correct error processing in exec-next command..

This patch uses changes from https://reviews.llvm.org/D47991. Is allows to:

(gdb)
-file-exec-and-symbols "bash"
^done
(gdb)
=library-loaded,id="/bin/bash",target-name="/bin/bash",host-name="/bin/bash",symbols-loaded="0",loaded_addr="-",size="0"
-exec-next
^error,msg="this SBThread object is invalid"

instead of simple ^running message.

Sun, Jun 10, 7:55 AM
apolyakov created D47992: [lldb-mi] Correct error processing in exec-next command..
Sun, Jun 10, 7:53 AM
apolyakov added a comment to D47991: Improve SBThread's stepping API using SBError parameter..

Also, I suggest to make similar things in other SBThread methods like StepOut etc.

Sun, Jun 10, 7:52 AM
apolyakov created D47991: Improve SBThread's stepping API using SBError parameter..
Sun, Jun 10, 7:50 AM

Sat, Jun 9

apolyakov committed rL334350: [lldb, lldb-mi] Re-implement MI -exec-continue command..
[lldb, lldb-mi] Re-implement MI -exec-continue command.
Sat, Jun 9, 8:16 AM
apolyakov closed D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command..
Sat, Jun 9, 8:16 AM

Fri, Jun 8

apolyakov added a comment to D47914: [lldb-mi] Add overloaded method for setting an error..

No, it's not used in a subsequent commit. Moreover, I think that we should revert this commit sometimes in a future, since it doesn't provide additional useful functionality.

Fri, Jun 8, 9:16 AM
apolyakov added inline comments to D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command..
Fri, Jun 8, 2:23 AM

Thu, Jun 7

apolyakov committed rL334245: [lldb-mi] Add overloaded method for setting an error..
[lldb-mi] Add overloaded method for setting an error.
Thu, Jun 7, 4:08 PM
apolyakov closed D47914: [lldb-mi] Add overloaded method for setting an error..
Thu, Jun 7, 4:08 PM
apolyakov created D47914: [lldb-mi] Add overloaded method for setting an error..
Thu, Jun 7, 3:43 PM
apolyakov committed rL334215: [lldb-mi] Re-implement MI -exec-next command..
[lldb-mi] Re-implement MI -exec-next command.
Thu, Jun 7, 12:13 PM
apolyakov closed D47797: [lldb-mi] Re-implement MI -exec-next command..
Thu, Jun 7, 12:13 PM