- User Since
- Jun 7 2018, 12:06 PM (9 w, 6 d)
Thu, Aug 9
I think those options don't fit. I'm looking for behavior like this:
~/workspace/gsoc/build/bin/lldb-server gdbserver --pipe 1 localhost:0 36251
Here lldb-server prints out the port number he is listening on and continues running.
It seems that target-select-so-path.test hangs on macOS. Thanks to @t.p.northover for noting this.
Tue, Aug 7
Sure, will do it.
Splitted the patch into two parts: this part with the new API and another one with re-implementing of target-select command.
The second part will be committed separately.
Wed, Aug 1
@clayborg can you explain what are you worry about because I don't completely understand you? As I said, all lldb-mi commands print their result to STDOUT, AFAIK, an IDE should parse it and then show in a GUI.
Tue, Jul 31
Changed the order of if statements to follow llvm coding standards.
Made error handling more meaningful: added different error messages for cases - empty <from> path and empty <to> path.
Added converting from const char * to ConstString, documented new API.
So, do you have any thoughts about this approach letting the debugserver choose a tcp port and patch overall?
Mon, Jul 30
Thu, Jul 26
It seems that it's impossible to get HandleProcessEventStateSuspended called on Linux, so I've copied code of this patch into
HandleProcessEventStateStopped to check new output.
Now tcp port is choosing by debugserver.
Wed, Jul 25
Moved test from bash to python, removed unnecessary Target::AppendImageSearchPath.
Thanks, I used this lldb-server gdbserver --pipe 0 localhost:0 and got a port chosen by debugserver. But to let lldb-mi know about this port we need an additional script, is python a good choice for that?
packages/Python/lldbsuite/test/tools/lldb-mi/signal/TestMiSignal.py test contains port = 12000 + random.randint(0, 3999).
What do you think about running tests with a hardcoded port number(as it's done in a web-services). Doing this, we get rid of additional scripts and os-specific things. AFAIK, debugserver even has its own default port.
Tue, Jul 24
Mon, Jul 23
You mean that it's unreasonable to provide such an output to stdout since MI clients are text redactors, IDE and not people?
Another approach is to implement SBTargetSettings' functionality such as serialization inside lldb_private TargetProperties class and then just add an API to the SBTarget. For example:
Sat, Jul 21
Thu, Jul 19
Converted data-info-line python test to a lit one.
Jul 13 2018
@stella.stamenova Done in r337064.
It would be good to convert to LIT as more tests as we can. I'll do this in one of a next patches. Let's continue with this one?
Jul 9 2018
Could you please provide an output of this command on Windows: E:\_work\4\b\LLVMBuild\Release\bin\lldb-mi.EXE --synchronous E:\_work\4\b\LLVMBuild\tools\lldb\lit\tools\lldb-mi\symbol\Output\symbol-list-lines.test.tmp < E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol\symbol-list-lines.test? I'll try to find out what causes a failure.
Returned accidentally removed backslashes in self.expect pattern, removed comment from:
#include <string> // For std::to_string.
Jul 8 2018
Jul 7 2018
Jul 6 2018
Unfortunately, I don't have an opportunity to check this out on windows, but if this works, I'll be glad that someone found out how to fix compilation failure on windows.
Jul 3 2018
Jul 2 2018
Removed sb_target.IsDummy() since IsDummy won't be a member of SBTarget class. Now sb_target == rSessionInfo.GetDebugger().GetDummyTarget() is used for this goal.
Updated passing an argument to find_compile_units function.
Abandoned since suggested functionality is optional.
It's hard to choose something, both variants are good enough. But, if there is no necessity in such a method, we can drop it.
I think we can remove comments added by me and commit patch as it is. Any thoughts about it?
Removed inline keyword.
Added documentation and tests.
Update comment. It still needs a review, thanks for your time.
Jun 30 2018
Jun 29 2018
Added description to source files and commit message.
Jun 25 2018
Removed duplicated and error prone(without --synchronous option) testing.
Removed unnecessary this->.
Jun 24 2018
You are right about python tests. Let's remove them.
Jun 23 2018
[WIP] Fully test -exec-interrupt command. It needs a program being executed at the moment of debugging to stop it.
Removed accidentally added comment, added const qualifier to lambdas.
Jun 22 2018
Would be really nice to get review of this patch before this weekend. Thanks for your time, folks.