apolyakov (Alexander Polyakov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2018, 12:06 PM (19 w, 1 d)

Recent Activity

Tue, Sep 25

apolyakov committed rL343033: [lldb-mi] Fix bugs in target-select-so-path.test.
[lldb-mi] Fix bugs in target-select-so-path.test
Tue, Sep 25, 2:51 PM
apolyakov committed rLLDB343033: [lldb-mi] Fix bugs in target-select-so-path.test.
[lldb-mi] Fix bugs in target-select-so-path.test
Tue, Sep 25, 2:51 PM
apolyakov closed D52498: [lldb-mi] Fix bugs in target-select-so-path.test.
Tue, Sep 25, 2:51 PM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Tue, Sep 25, 11:03 AM
apolyakov updated the diff for D52498: [lldb-mi] Fix bugs in target-select-so-path.test.

Changed the test to use %python variable instead of python

Tue, Sep 25, 10:59 AM
apolyakov updated the diff for D52498: [lldb-mi] Fix bugs in target-select-so-path.test.

Changed python version required to use 'pass_fds' argument to 3.2.
I tested this patch with python 2.7 and 3.5.

Tue, Sep 25, 9:31 AM
apolyakov updated the diff for D52498: [lldb-mi] Fix bugs in target-select-so-path.test.

Removed the shebang line since we call the script via python ... so that line doesn't matter.

Tue, Sep 25, 8:01 AM
apolyakov added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Thanks Pavel, I fixed it here https://reviews.llvm.org/D52498.

Tue, Sep 25, 7:55 AM
apolyakov created D52498: [lldb-mi] Fix bugs in target-select-so-path.test.
Tue, Sep 25, 7:54 AM

Mon, Sep 24

apolyakov committed rLLDB342915: [lldb-mi] Fix hanging of target-select-so-path.test.
[lldb-mi] Fix hanging of target-select-so-path.test
Mon, Sep 24, 12:14 PM
apolyakov committed rL342915: [lldb-mi] Fix hanging of target-select-so-path.test.
[lldb-mi] Fix hanging of target-select-so-path.test
Mon, Sep 24, 12:14 PM
apolyakov closed D52139: [lldb-mi] Fix hanging of target-select-so-path.test.
Mon, Sep 24, 12:14 PM
apolyakov removed a dependency for D52139: [lldb-mi] Fix hanging of target-select-so-path.test: D49739: Add new API to SBTarget class.
Mon, Sep 24, 12:08 PM
apolyakov removed a dependent revision for D49739: Add new API to SBTarget class: D52139: [lldb-mi] Fix hanging of target-select-so-path.test.
Mon, Sep 24, 12:08 PM
apolyakov updated the diff for D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Reduced timer from 120 to 30 seconds.

Mon, Sep 24, 10:30 AM
apolyakov added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

If so, we can try to run the script with python2.x. @teemperor can you try to modify target-select-so-path.test this way:
change # RUN: python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s to
# RUN: python2 %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s

Mon, Sep 24, 7:20 AM

Sat, Sep 22

apolyakov added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

AFAIR, adding an exit(...) to ConnectToRemote won't solve this problem. The test will still be failing on Arch.

Sat, Sep 22, 4:03 PM

Fri, Sep 21

apolyakov added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Do you mean ConnectToRemote method from lldb/tools/lldb-server/lldb-gdbserver.cpp?

Fri, Sep 21, 2:25 PM

Thu, Sep 20

apolyakov added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Can you provide some logs? For example, you might be able to run this test (llvm-lit -a -vv .../target-select-so-path.test) and kill lldb-mi and filecheck processes if they hang. Also, information about which processes hang would be useful too (lldb-mi or filecheck or maybe both).

Thu, Sep 20, 12:56 PM
apolyakov updated the diff for D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Thanks to @tatyana-krasnukha for the idea about a timer. Added a timer to target-select-so-path test.

Thu, Sep 20, 11:41 AM
apolyakov added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Can you provide some logs? For example, you might be able to run this test (llvm-lit -a -vv .../target-select-so-path.test) and kill lldb-mi and filecheck processes if they hang. Also, information about which processes hang would be useful too (lldb-mi or filecheck or maybe both).

Thu, Sep 20, 10:28 AM
apolyakov updated the diff for D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

I found out that the reason of hanging of the test suite was in incorrect usage of Filecheck and lldb-mi processes in target-select-so-path.test. Current patch has been tested on CentOS 7.

Thu, Sep 20, 8:00 AM

Sep 17 2018

apolyakov added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

It seems reasonable, I'll look at this.

Sep 17 2018, 3:24 PM

Sep 15 2018

apolyakov created D52139: [lldb-mi] Fix hanging of target-select-so-path.test.
Sep 15 2018, 12:53 PM
apolyakov added a comment to D48802: [lldb-mi] Re-implement symbol-list-lines command..

symbol-list-lines.test fails on Linux too, input is compiled with gcc.

Sep 15 2018, 11:17 AM
apolyakov committed rLLDB342329: [lldb-mi] Correct regex in the symbol-list-lines test.
[lldb-mi] Correct regex in the symbol-list-lines test
Sep 15 2018, 10:08 AM
apolyakov committed rL342329: [lldb-mi] Correct regex in the symbol-list-lines test.
[lldb-mi] Correct regex in the symbol-list-lines test
Sep 15 2018, 10:08 AM
apolyakov closed D52101: [lldb-mi] Correct regex in the symbol-list-lines test.
Sep 15 2018, 10:08 AM

Sep 14 2018

apolyakov added a comment to D52101: [lldb-mi] Correct regex in the symbol-list-lines test.

I've created this revision to be sure that you don't think that this approach is some kind of hack.

Sep 14 2018, 9:05 AM
apolyakov created D52101: [lldb-mi] Correct regex in the symbol-list-lines test.
Sep 14 2018, 9:03 AM

Sep 7 2018

apolyakov committed rLLDB341667: [ARC] Make char unsigned by default.
[ARC] Make char unsigned by default
Sep 7 2018, 7:50 AM
apolyakov committed rL341667: [ARC] Make char unsigned by default.
[ARC] Make char unsigned by default
Sep 7 2018, 7:50 AM
apolyakov closed D51594: [ARC] Make char unsigned by default.
Sep 7 2018, 7:50 AM

Sep 3 2018

apolyakov added a reviewer for D51594: [ARC] Make char unsigned by default: clayborg.
Sep 3 2018, 9:22 AM
apolyakov created D51594: [ARC] Make char unsigned by default.
Sep 3 2018, 6:41 AM

Aug 9 2018

apolyakov added inline comments to D50525: [WIP] Move lldb-mi interpreter tests to LIT.
Aug 9 2018, 2:32 PM
apolyakov added inline comments to D50525: [WIP] Move lldb-mi interpreter tests to LIT.
Aug 9 2018, 1:44 PM
apolyakov added inline comments to D50525: [WIP] Move lldb-mi interpreter tests to LIT.
Aug 9 2018, 1:36 PM
apolyakov created D50525: [WIP] Move lldb-mi interpreter tests to LIT.
Aug 9 2018, 12:07 PM
apolyakov added a comment to D49739: Add new API to SBTarget class.

I think those options don't fit. I'm looking for behavior like this:

~/workspace/gsoc/build/bin/lldb-server gdbserver --pipe 1 localhost:0
36251

Here lldb-server prints out the port number it is listening on and continues running.

Aug 9 2018, 10:36 AM
apolyakov updated subscribers of D49739: Add new API to SBTarget class.

It seems that target-select-so-path.test hangs on macOS. Thanks to @t.p.northover for noting this.

Aug 9 2018, 6:20 AM

Aug 7 2018

apolyakov committed rLLDB339189: Add documentation for SBTarget::AppendImageSearchPath.
Add documentation for SBTarget::AppendImageSearchPath
Aug 7 2018, 2:42 PM
apolyakov committed rL339189: Add documentation for SBTarget::AppendImageSearchPath.
Add documentation for SBTarget::AppendImageSearchPath
Aug 7 2018, 2:42 PM
apolyakov committed rLLDB339178: [lldb-mi] Re-implement target-select command.
[lldb-mi] Re-implement target-select command
Aug 7 2018, 1:46 PM
apolyakov committed rL339178: [lldb-mi] Re-implement target-select command.
[lldb-mi] Re-implement target-select command
Aug 7 2018, 1:46 PM
apolyakov added a comment to D49739: Add new API to SBTarget class.

Sure, will do it.

Aug 7 2018, 1:36 PM
apolyakov committed rLLDB339175: Add new API to SBTarget class.
Add new API to SBTarget class
Aug 7 2018, 1:24 PM
apolyakov committed rL339175: Add new API to SBTarget class.
Add new API to SBTarget class
Aug 7 2018, 1:24 PM
apolyakov closed D49739: Add new API to SBTarget class.
Aug 7 2018, 1:24 PM
apolyakov updated the diff for D49739: Add new API to SBTarget class.

Splitted the patch into two parts: this part with the new API and another one with re-implementing of target-select command.
The second part will be committed separately.

Aug 7 2018, 1:19 PM
apolyakov committed rLLDB339160: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..
[lldb-mi] Re-implement MI HandleProcessEventStateSuspended.
Aug 7 2018, 10:56 AM
apolyakov committed rL339160: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..
[lldb-mi] Re-implement MI HandleProcessEventStateSuspended.
Aug 7 2018, 10:56 AM
apolyakov closed D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..
Aug 7 2018, 10:55 AM

Aug 1 2018

apolyakov added a comment to D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..

@clayborg can you explain what are you worry about because I don't completely understand you? As I said, all lldb-mi commands print their result to STDOUT, AFAIK, an IDE should parse it and then show in a GUI.

Aug 1 2018, 12:21 PM

Jul 31 2018

apolyakov updated the diff for D49739: Add new API to SBTarget class.

Changed the order of if statements to follow llvm coding standards.

Jul 31 2018, 1:41 PM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Jul 31 2018, 12:56 PM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Jul 31 2018, 12:42 PM
apolyakov updated the diff for D49739: Add new API to SBTarget class.

Made error handling more meaningful: added different error messages for cases - empty <from> path and empty <to> path.

Jul 31 2018, 11:05 AM
apolyakov updated the diff for D49739: Add new API to SBTarget class.

Added converting from const char * to ConstString, documented new API.

Jul 31 2018, 10:30 AM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Jul 31 2018, 9:51 AM
apolyakov added a comment to D49739: Add new API to SBTarget class.

OK, thank you for respond. Then, I think, we should wait for review from @clayborg or @aprantl, and if they accept the patch I'll divide it into two parts: SB API part and target-select one.

Jul 31 2018, 9:46 AM
apolyakov added a comment to D49739: Add new API to SBTarget class.

So, do you have any thoughts about this approach letting the debugserver choose a tcp port and patch overall?

Jul 31 2018, 8:50 AM

Jul 30 2018

apolyakov added a comment to D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..

I still don't get why we are printing process stopped information to STDOUT. MI is a machine interface for a IDE. The IDE should be showing the process state in the GUI.

Jul 30 2018, 11:49 AM

Jul 26 2018

apolyakov updated the diff for D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..

It seems that it's impossible to get HandleProcessEventStateSuspended called on Linux, so I've copied code of this patch into
HandleProcessEventStateStopped to check new output.

Jul 26 2018, 10:59 AM
apolyakov updated the diff for D49739: Add new API to SBTarget class.

Now tcp port is choosing by debugserver.

Jul 26 2018, 9:42 AM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Jul 26 2018, 8:16 AM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Jul 26 2018, 7:47 AM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Jul 26 2018, 6:10 AM

Jul 25 2018

apolyakov added inline comments to D49739: Add new API to SBTarget class.
Jul 25 2018, 12:35 PM
apolyakov updated the diff for D49739: Add new API to SBTarget class.

Moved test from bash to python, removed unnecessary Target::AppendImageSearchPath.

Jul 25 2018, 11:06 AM
apolyakov added a comment to D49739: Add new API to SBTarget class.

Thanks, I used this lldb-server gdbserver --pipe 0 localhost:0 and got a port chosen by debugserver. But to let lldb-mi know about this port we need an additional script, is python a good choice for that?

Jul 25 2018, 3:42 AM
apolyakov added a comment to D49739: Add new API to SBTarget class.

packages/Python/lldbsuite/test/tools/lldb-mi/signal/TestMiSignal.py test contains port = 12000 + random.randint(0, 3999).

Jul 25 2018, 3:17 AM
apolyakov added a comment to D49739: Add new API to SBTarget class.

What do you think about running tests with a hardcoded port number(as it's done in a web-services). Doing this, we get rid of additional scripts and os-specific things. AFAIK, debugserver even has its own default port.

Jul 25 2018, 2:44 AM

Jul 24 2018

apolyakov created D49739: Add new API to SBTarget class.
Jul 24 2018, 9:02 AM

Jul 23 2018

apolyakov added a comment to D47302: [WIP] New class SBTargetSettings to store and manipulate all target's properties..

We could end up moving anything that is set by a target property into the lldb_private target property class if it isn't already there and then that would fix things.

Jul 23 2018, 9:52 AM
apolyakov added a comment to D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..

You mean that it's unreasonable to provide such an output to stdout since MI clients are text redactors, IDE and not people?

Jul 23 2018, 7:28 AM
apolyakov added a comment to D47302: [WIP] New class SBTargetSettings to store and manipulate all target's properties..

Another approach is to implement SBTargetSettings' functionality such as serialization inside lldb_private TargetProperties class and then just add an API to the SBTarget. For example:
void SBTarget::SerializeProperties(...)

Jul 23 2018, 7:22 AM
apolyakov committed rL337692: Fix windows build after r337689.
Fix windows build after r337689
Jul 23 2018, 7:10 AM
apolyakov committed rL337689: [lldb-mi] Re-implement data-info-line command..
[lldb-mi] Re-implement data-info-line command.
Jul 23 2018, 6:02 AM
apolyakov closed D49062: [lldb-mi] Re-implement data-info-line command..
Jul 23 2018, 6:02 AM

Jul 21 2018

apolyakov added a comment to D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..

So with CMICmnLLDBDebuggerHandleEvents::HandleProcessEventStateSuspended() it will report a bunch of text back through the MI interface with this each time? Why would it do that? I would assume that the MI interface would handle this programmatically?

Jul 21 2018, 3:39 PM
apolyakov retitled D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended. from [lldb-mi] Re-implement MI HandleProcessEventStateSuspended. to [WIP] Re-implement MI HandleProcessEventStateSuspended..
Jul 21 2018, 4:55 AM
apolyakov added inline comments to D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..
Jul 21 2018, 1:51 AM
apolyakov created D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..
Jul 21 2018, 1:48 AM

Jul 19 2018

apolyakov updated the diff for D49062: [lldb-mi] Re-implement data-info-line command..

Converted data-info-line python test to a lit one.

Jul 19 2018, 9:59 AM

Jul 13 2018

apolyakov added a comment to D48802: [lldb-mi] Re-implement symbol-list-lines command..

@stella.stamenova Done in r337064.

Jul 13 2018, 3:59 PM
apolyakov added a comment to D49062: [lldb-mi] Re-implement data-info-line command..

It would be good to convert to LIT as more tests as we can. I'll do this in one of a next patches. Let's continue with this one?

Jul 13 2018, 3:56 PM
apolyakov committed rL337064: [lldb-mi] Make symbol-list-lines.test XFAIL on Windows.
[lldb-mi] Make symbol-list-lines.test XFAIL on Windows
Jul 13 2018, 3:46 PM
apolyakov added a comment to D48802: [lldb-mi] Re-implement symbol-list-lines command..

@apolyakov Perhaps we can mark the test as XFAIL on Windows while you investigate. Any objections?

Jul 13 2018, 1:41 PM

Jul 9 2018

apolyakov added inline comments to D49062: [lldb-mi] Re-implement data-info-line command..
Jul 9 2018, 11:26 AM
apolyakov added a comment to D48802: [lldb-mi] Re-implement symbol-list-lines command..

Could you please provide an output of this command on Windows: E:\_work\4\b\LLVMBuild\Release\bin\lldb-mi.EXE --synchronous E:\_work\4\b\LLVMBuild\tools\lldb\lit\tools\lldb-mi\symbol\Output\symbol-list-lines.test.tmp < E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol\symbol-list-lines.test? I'll try to find out what causes a failure.

Jul 9 2018, 10:57 AM
apolyakov added inline comments to D49062: [lldb-mi] Re-implement data-info-line command..
Jul 9 2018, 10:04 AM
apolyakov updated the diff for D49062: [lldb-mi] Re-implement data-info-line command..

Returned accidentally removed backslashes in self.expect pattern, removed comment from:
#include <string> // For std::to_string.

Jul 9 2018, 9:26 AM

Jul 8 2018

apolyakov created D49062: [lldb-mi] Re-implement data-info-line command..
Jul 8 2018, 3:56 PM

Jul 7 2018

apolyakov committed rL336494: Add LLDB_API to SBAddress's operator==..
Add LLDB_API to SBAddress's operator==.
Jul 7 2018, 12:00 PM
apolyakov closed D49006: Add LLDB_API to SBAddress's operator==.
Jul 7 2018, 11:59 AM

Jul 6 2018

apolyakov added a comment to D49006: Add LLDB_API to SBAddress's operator==.

Unfortunately, I don't have an opportunity to check this out on windows, but if this works, I'll be glad that someone found out how to fix compilation failure on windows.

Jul 6 2018, 10:27 AM
apolyakov accepted D49006: Add LLDB_API to SBAddress's operator==.

LGTM!

Jul 6 2018, 10:03 AM

Jul 3 2018

apolyakov committed rL336235: Ammend "Fix MSVC2015 compilation failure after r336206 patch"..
Ammend "Fix MSVC2015 compilation failure after r336206 patch".
Jul 3 2018, 3:55 PM
apolyakov committed rL336212: Fix MSVC2015 compilation failure after r336206 patch..
Fix MSVC2015 compilation failure after r336206 patch.
Jul 3 2018, 9:12 AM