apolyakov (Alexander Polyakov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2018, 12:06 PM (9 w, 6 d)

Recent Activity

Thu, Aug 9

apolyakov added inline comments to D50525: [WIP] Move lldb-mi interpreter tests to LIT.
Thu, Aug 9, 2:32 PM
apolyakov added inline comments to D50525: [WIP] Move lldb-mi interpreter tests to LIT.
Thu, Aug 9, 1:44 PM
apolyakov added inline comments to D50525: [WIP] Move lldb-mi interpreter tests to LIT.
Thu, Aug 9, 1:36 PM
apolyakov created D50525: [WIP] Move lldb-mi interpreter tests to LIT.
Thu, Aug 9, 12:07 PM
apolyakov added a comment to D49739: Add new API to SBTarget class.

I think those options don't fit. I'm looking for behavior like this:

~/workspace/gsoc/build/bin/lldb-server gdbserver --pipe 1 localhost:0
36251

Here lldb-server prints out the port number he is listening on and continues running.

Thu, Aug 9, 10:36 AM
apolyakov updated subscribers of D49739: Add new API to SBTarget class.

It seems that target-select-so-path.test hangs on macOS. Thanks to @t.p.northover for noting this.

Thu, Aug 9, 6:20 AM

Tue, Aug 7

apolyakov committed rLLDB339189: Add documentation for SBTarget::AppendImageSearchPath.
Add documentation for SBTarget::AppendImageSearchPath
Tue, Aug 7, 2:42 PM
apolyakov committed rL339189: Add documentation for SBTarget::AppendImageSearchPath.
Add documentation for SBTarget::AppendImageSearchPath
Tue, Aug 7, 2:42 PM
apolyakov committed rLLDB339178: [lldb-mi] Re-implement target-select command.
[lldb-mi] Re-implement target-select command
Tue, Aug 7, 1:46 PM
apolyakov committed rL339178: [lldb-mi] Re-implement target-select command.
[lldb-mi] Re-implement target-select command
Tue, Aug 7, 1:46 PM
apolyakov added a comment to D49739: Add new API to SBTarget class.

Sure, will do it.

Tue, Aug 7, 1:36 PM
apolyakov committed rLLDB339175: Add new API to SBTarget class.
Add new API to SBTarget class
Tue, Aug 7, 1:24 PM
apolyakov committed rL339175: Add new API to SBTarget class.
Add new API to SBTarget class
Tue, Aug 7, 1:24 PM
apolyakov closed D49739: Add new API to SBTarget class.
Tue, Aug 7, 1:24 PM
apolyakov updated the diff for D49739: Add new API to SBTarget class.

Splitted the patch into two parts: this part with the new API and another one with re-implementing of target-select command.
The second part will be committed separately.

Tue, Aug 7, 1:19 PM
apolyakov committed rLLDB339160: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..
[lldb-mi] Re-implement MI HandleProcessEventStateSuspended.
Tue, Aug 7, 10:56 AM
apolyakov committed rL339160: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..
[lldb-mi] Re-implement MI HandleProcessEventStateSuspended.
Tue, Aug 7, 10:56 AM
apolyakov closed D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..
Tue, Aug 7, 10:55 AM

Wed, Aug 1

apolyakov added a comment to D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..

@clayborg can you explain what are you worry about because I don't completely understand you? As I said, all lldb-mi commands print their result to STDOUT, AFAIK, an IDE should parse it and then show in a GUI.

Wed, Aug 1, 12:21 PM

Tue, Jul 31

apolyakov updated the diff for D49739: Add new API to SBTarget class.

Changed the order of if statements to follow llvm coding standards.

Tue, Jul 31, 1:41 PM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Tue, Jul 31, 12:56 PM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Tue, Jul 31, 12:42 PM
apolyakov updated the diff for D49739: Add new API to SBTarget class.

Made error handling more meaningful: added different error messages for cases - empty <from> path and empty <to> path.

Tue, Jul 31, 11:05 AM
apolyakov updated the diff for D49739: Add new API to SBTarget class.

Added converting from const char * to ConstString, documented new API.

Tue, Jul 31, 10:30 AM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Tue, Jul 31, 9:51 AM
apolyakov added a comment to D49739: Add new API to SBTarget class.

OK, thank you for respond. Then, I think, we should wait for review from @clayborg or @aprantl, and if they accept the patch I'll divide it into two parts: SB API part and target-select one.

Tue, Jul 31, 9:46 AM
apolyakov added a comment to D49739: Add new API to SBTarget class.

So, do you have any thoughts about this approach letting the debugserver choose a tcp port and patch overall?

Tue, Jul 31, 8:50 AM

Mon, Jul 30

apolyakov added a comment to D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..

I still don't get why we are printing process stopped information to STDOUT. MI is a machine interface for a IDE. The IDE should be showing the process state in the GUI.

Mon, Jul 30, 11:49 AM

Thu, Jul 26

apolyakov updated the diff for D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..

It seems that it's impossible to get HandleProcessEventStateSuspended called on Linux, so I've copied code of this patch into
HandleProcessEventStateStopped to check new output.

Thu, Jul 26, 10:59 AM
apolyakov updated the diff for D49739: Add new API to SBTarget class.

Now tcp port is choosing by debugserver.

Thu, Jul 26, 9:42 AM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Thu, Jul 26, 8:16 AM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Thu, Jul 26, 7:47 AM
apolyakov added inline comments to D49739: Add new API to SBTarget class.
Thu, Jul 26, 6:10 AM

Wed, Jul 25

apolyakov added inline comments to D49739: Add new API to SBTarget class.
Wed, Jul 25, 12:35 PM
apolyakov updated the diff for D49739: Add new API to SBTarget class.

Moved test from bash to python, removed unnecessary Target::AppendImageSearchPath.

Wed, Jul 25, 11:06 AM
apolyakov added a comment to D49739: Add new API to SBTarget class.

Thanks, I used this lldb-server gdbserver --pipe 0 localhost:0 and got a port chosen by debugserver. But to let lldb-mi know about this port we need an additional script, is python a good choice for that?

Wed, Jul 25, 3:42 AM
apolyakov added a comment to D49739: Add new API to SBTarget class.

packages/Python/lldbsuite/test/tools/lldb-mi/signal/TestMiSignal.py test contains port = 12000 + random.randint(0, 3999).

Wed, Jul 25, 3:17 AM
apolyakov added a comment to D49739: Add new API to SBTarget class.

What do you think about running tests with a hardcoded port number(as it's done in a web-services). Doing this, we get rid of additional scripts and os-specific things. AFAIK, debugserver even has its own default port.

Wed, Jul 25, 2:44 AM

Tue, Jul 24

apolyakov created D49739: Add new API to SBTarget class.
Tue, Jul 24, 9:02 AM

Mon, Jul 23

apolyakov added a comment to D47302: [WIP] New class SBTargetSettings to store and manipulate all target's properties..

We could end up moving anything that is set by a target property into the lldb_private target property class if it isn't already there and then that would fix things.

Mon, Jul 23, 9:52 AM
apolyakov added a comment to D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..

You mean that it's unreasonable to provide such an output to stdout since MI clients are text redactors, IDE and not people?

Mon, Jul 23, 7:28 AM
apolyakov added a comment to D47302: [WIP] New class SBTargetSettings to store and manipulate all target's properties..

Another approach is to implement SBTargetSettings' functionality such as serialization inside lldb_private TargetProperties class and then just add an API to the SBTarget. For example:
void SBTarget::SerializeProperties(...)

Mon, Jul 23, 7:22 AM
apolyakov committed rL337692: Fix windows build after r337689.
Fix windows build after r337689
Mon, Jul 23, 7:10 AM
apolyakov committed rL337689: [lldb-mi] Re-implement data-info-line command..
[lldb-mi] Re-implement data-info-line command.
Mon, Jul 23, 6:02 AM
apolyakov closed D49062: [lldb-mi] Re-implement data-info-line command..
Mon, Jul 23, 6:02 AM

Sat, Jul 21

apolyakov added a comment to D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..

So with CMICmnLLDBDebuggerHandleEvents::HandleProcessEventStateSuspended() it will report a bunch of text back through the MI interface with this each time? Why would it do that? I would assume that the MI interface would handle this programmatically?

Sat, Jul 21, 3:39 PM
apolyakov retitled D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended. from [lldb-mi] Re-implement MI HandleProcessEventStateSuspended. to [WIP] Re-implement MI HandleProcessEventStateSuspended..
Sat, Jul 21, 4:55 AM
apolyakov added inline comments to D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..
Sat, Jul 21, 1:51 AM
apolyakov created D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..
Sat, Jul 21, 1:48 AM

Thu, Jul 19

apolyakov updated the diff for D49062: [lldb-mi] Re-implement data-info-line command..

Converted data-info-line python test to a lit one.

Thu, Jul 19, 9:59 AM

Jul 13 2018

apolyakov added a comment to D48802: [lldb-mi] Re-implement symbol-list-lines command..

@stella.stamenova Done in r337064.

Jul 13 2018, 3:59 PM
apolyakov added a comment to D49062: [lldb-mi] Re-implement data-info-line command..

It would be good to convert to LIT as more tests as we can. I'll do this in one of a next patches. Let's continue with this one?

Jul 13 2018, 3:56 PM
apolyakov committed rL337064: [lldb-mi] Make symbol-list-lines.test XFAIL on Windows.
[lldb-mi] Make symbol-list-lines.test XFAIL on Windows
Jul 13 2018, 3:46 PM
apolyakov added a comment to D48802: [lldb-mi] Re-implement symbol-list-lines command..

@apolyakov Perhaps we can mark the test as XFAIL on Windows while you investigate. Any objections?

Jul 13 2018, 1:41 PM

Jul 9 2018

apolyakov added inline comments to D49062: [lldb-mi] Re-implement data-info-line command..
Jul 9 2018, 11:26 AM
apolyakov added a comment to D48802: [lldb-mi] Re-implement symbol-list-lines command..

Could you please provide an output of this command on Windows: E:\_work\4\b\LLVMBuild\Release\bin\lldb-mi.EXE --synchronous E:\_work\4\b\LLVMBuild\tools\lldb\lit\tools\lldb-mi\symbol\Output\symbol-list-lines.test.tmp < E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol\symbol-list-lines.test? I'll try to find out what causes a failure.

Jul 9 2018, 10:57 AM
apolyakov added inline comments to D49062: [lldb-mi] Re-implement data-info-line command..
Jul 9 2018, 10:04 AM
apolyakov updated the diff for D49062: [lldb-mi] Re-implement data-info-line command..

Returned accidentally removed backslashes in self.expect pattern, removed comment from:
#include <string> // For std::to_string.

Jul 9 2018, 9:26 AM

Jul 8 2018

apolyakov created D49062: [lldb-mi] Re-implement data-info-line command..
Jul 8 2018, 3:56 PM

Jul 7 2018

apolyakov committed rL336494: Add LLDB_API to SBAddress's operator==..
Add LLDB_API to SBAddress's operator==.
Jul 7 2018, 12:00 PM
apolyakov closed D49006: Add LLDB_API to SBAddress's operator==.
Jul 7 2018, 11:59 AM

Jul 6 2018

apolyakov added a comment to D49006: Add LLDB_API to SBAddress's operator==.

Unfortunately, I don't have an opportunity to check this out on windows, but if this works, I'll be glad that someone found out how to fix compilation failure on windows.

Jul 6 2018, 10:27 AM
apolyakov accepted D49006: Add LLDB_API to SBAddress's operator==.

LGTM!

Jul 6 2018, 10:03 AM

Jul 3 2018

apolyakov committed rL336235: Ammend "Fix MSVC2015 compilation failure after r336206 patch"..
Ammend "Fix MSVC2015 compilation failure after r336206 patch".
Jul 3 2018, 3:55 PM
apolyakov committed rL336212: Fix MSVC2015 compilation failure after r336206 patch..
Fix MSVC2015 compilation failure after r336206 patch.
Jul 3 2018, 9:12 AM
apolyakov committed rL336206: [lldb-mi] Re-implement symbol-list-lines command..
[lldb-mi] Re-implement symbol-list-lines command.
Jul 3 2018, 8:45 AM
apolyakov closed D48802: [lldb-mi] Re-implement symbol-list-lines command..
Jul 3 2018, 8:45 AM
apolyakov committed rL336200: Add new API to SBTarget and SBModule classes..
Add new API to SBTarget and SBModule classes.
Jul 3 2018, 7:27 AM
apolyakov closed D48801: Add new API to SBTarget and SBModule classes..
Jul 3 2018, 7:27 AM

Jul 2 2018

apolyakov updated the diff for D48802: [lldb-mi] Re-implement symbol-list-lines command..

Removed sb_target.IsDummy() since IsDummy won't be a member of SBTarget class. Now sb_target == rSessionInfo.GetDebugger().GetDummyTarget() is used for this goal.

Jul 2 2018, 7:02 PM
apolyakov updated the diff for D48801: Add new API to SBTarget and SBModule classes..

Updated passing an argument to find_compile_units function.

Jul 2 2018, 6:59 PM
apolyakov abandoned D48775: Add new SBTarget::IsDummy method..

Abandoned since suggested functionality is optional.

Jul 2 2018, 6:17 PM
apolyakov added a comment to D48775: Add new SBTarget::IsDummy method..

It's hard to choose something, both variants are good enough. But, if there is no necessity in such a method, we can drop it.

Jul 2 2018, 5:45 PM
apolyakov added a comment to D48775: Add new SBTarget::IsDummy method..

I think we can remove comments added by me and commit patch as it is. Any thoughts about it?

Jul 2 2018, 5:05 PM
apolyakov committed rL336155: [lldb-mi] Re-implement a few MI commands..
[lldb-mi] Re-implement a few MI commands.
Jul 2 2018, 4:59 PM
apolyakov closed D48520: [lldb-mi] Re-implement a few MI commands..
Jul 2 2018, 4:59 PM
apolyakov added inline comments to D48801: Add new API to SBTarget and SBModule classes..
Jul 2 2018, 3:53 PM
apolyakov added inline comments to D48801: Add new API to SBTarget and SBModule classes..
Jul 2 2018, 3:50 PM
apolyakov updated the diff for D48802: [lldb-mi] Re-implement symbol-list-lines command..

Removed inline keyword.

Jul 2 2018, 3:42 PM
apolyakov updated the diff for D48801: Add new API to SBTarget and SBModule classes..

Added documentation and tests.

Jul 2 2018, 3:39 PM
apolyakov added a comment to D48520: [lldb-mi] Re-implement a few MI commands..

Update comment. It still needs a review, thanks for your time.

Jul 2 2018, 12:12 PM

Jun 30 2018

apolyakov added inline comments to D48802: [lldb-mi] Re-implement symbol-list-lines command..
Jun 30 2018, 3:03 PM
apolyakov created D48802: [lldb-mi] Re-implement symbol-list-lines command..
Jun 30 2018, 5:06 AM
apolyakov created D48801: Add new API to SBTarget and SBModule classes..
Jun 30 2018, 5:00 AM

Jun 29 2018

apolyakov committed rL336009: [lldb-mi] Clean up and update a few MI commands..
[lldb-mi] Clean up and update a few MI commands.
Jun 29 2018, 1:03 PM
apolyakov closed D47992: [lldb-mi] Clean up and update a few MI commands..
Jun 29 2018, 1:03 PM
apolyakov updated the diff for D48775: Add new SBTarget::IsDummy method..

Added description to source files and commit message.

Jun 29 2018, 10:11 AM
apolyakov created D48775: Add new SBTarget::IsDummy method..
Jun 29 2018, 9:08 AM

Jun 25 2018

apolyakov committed rL335552: Fix windows build for r335541..
Fix windows build for r335541.
Jun 25 2018, 4:34 PM
apolyakov committed rL335541: Implement new methods for handling an error in MI commands..
Implement new methods for handling an error in MI commands.
Jun 25 2018, 3:06 PM
apolyakov closed D48295: Implement new methods for handling an error in MI commands..
Jun 25 2018, 3:06 PM
apolyakov added inline comments to D48520: [lldb-mi] Re-implement a few MI commands..
Jun 25 2018, 10:34 AM
apolyakov updated the diff for D48520: [lldb-mi] Re-implement a few MI commands..

Removed duplicated and error prone(without --synchronous option) testing.

Jun 25 2018, 10:05 AM
apolyakov updated the diff for D47992: [lldb-mi] Clean up and update a few MI commands..

Removed unnecessary this->.

Jun 25 2018, 8:03 AM

Jun 24 2018

apolyakov added a comment to D48520: [lldb-mi] Re-implement a few MI commands..

You are right about python tests. Let's remove them.

Jun 24 2018, 10:23 AM

Jun 23 2018

apolyakov added a comment to D48520: [lldb-mi] Re-implement a few MI commands..

[WIP] Fully test -exec-interrupt command. It needs a program being executed at the moment of debugging to stop it.

Jun 23 2018, 3:00 PM
apolyakov created D48520: [lldb-mi] Re-implement a few MI commands..
Jun 23 2018, 9:43 AM
apolyakov updated the diff for D47992: [lldb-mi] Clean up and update a few MI commands..

Removed accidentally added comment, added const qualifier to lambdas.

Jun 23 2018, 3:46 AM
apolyakov added inline comments to D47992: [lldb-mi] Clean up and update a few MI commands..
Jun 23 2018, 3:36 AM

Jun 22 2018

apolyakov added a comment to D47992: [lldb-mi] Clean up and update a few MI commands..

Would be really nice to get review of this patch before this weekend. Thanks for your time, folks.

Jun 22 2018, 11:31 AM