This is an archive of the discontinued LLVM Phabricator instance.

Differential D52054

Add missing MC dependency to llvm-exegesis/CMakeLists.txt
ClosedPublic

Authored by sbc100 on Sep 13 2018, 1:01 PM.

Details

Reviewers
DiamondLovesYou
Commits
rG9b3e7c365c3c: [llvm-exegesis] Add missing MC dependency to CMakeLists.txt
rL342180: [llvm-exegesis] Add missing MC dependency to CMakeLists.txt
Summary

See rL342148

This probably only shows up in BUILD_SHARED_LIBS=ON builds
which might explain how it crept in.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Sep 13 2018, 1:01 PM
Herald added subscribers: llvm-commits, courbet, tschuett and 2 others. · View Herald TranscriptSep 13 2018, 1:01 PM
sbc100 added a reviewer: DiamondLovesYou.Sep 13 2018, 1:02 PM
Harbormaster completed remote builds in B22610: Diff 165362.Sep 13 2018, 1:03 PM
DiamondLovesYou accepted this revision.Sep 13 2018, 1:40 PM

Indeed; discovered but only just before class. Thanks!

This revision is now accepted and ready to land.Sep 13 2018, 1:40 PM
Closed by commit rL342180: [llvm-exegesis] Add missing MC dependency to CMakeLists.txt (authored by sbc). · Explain WhySep 13 2018, 2:18 PM
This revision was automatically updated to reflect the committed changes.
lebedev.ri added a subscriber: lebedev.ri.Sep 13 2018, 2:27 PM

And a follow-up in rL342182.

Diffusion mentioned this in rL342182: LLVMExegesisX86Tests: link to LLVMCore, too..Sep 13 2018, 2:28 PM

Revision Contents

PathSize
llvm/
trunk/
tools/
llvm-exegesis/
1 line

Diff 165378

llvm/trunk/tools/llvm-exegesis/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
MC
Support Support
native native
) )
add_llvm_tool(llvm-exegesis add_llvm_tool(llvm-exegesis
llvm-exegesis.cpp llvm-exegesis.cpp
DEPENDS DEPENDS
Show All 19 Lines