Page MenuHomePhabricator

[Mips][FastISel] Fix selectBranch on icmp i1
ClosedPublic

Authored by draganm on Sep 13 2018, 9:49 AM.

Details

Summary

The rL337288 tried to fix result of icmp i1 when its input is not sanitized by
falling back to DagISel. While it now produces the correct result for bit 0,
the other bits can still hold arbitrary value which isn't supported by
MipsFastISel branch lowering. This patch fixes the issue by falling
back to DagISel in this case.

Diff Detail

Repository
rL LLVM

Event Timeline

draganm created this revision.Sep 13 2018, 9:49 AM
This revision is now accepted and ready to land.Sep 20 2018, 3:55 AM

Do you have commit access?

No, I do not have it.

Sorry, I still have to delete some redundant empty lines. I believe that @petarj will commit it later.

This revision was automatically updated to reflect the committed changes.