This is an archive of the discontinued LLVM Phabricator instance.

Differential D51897

[InstCombine] Partially revert rL341674 due to PR38897.
ClosedPublic

Authored by asbirlea on Sep 10 2018, 4:48 PM.

Details

Reviewers
craig.topper
spatel
Commits
rG116caa2920c5: [InstCombine] Partially revert rL341674 due to PR38897.
rL341883: [InstCombine] Partially revert rL341674 due to PR38897.
Summary

Revert min/max changes in rL341674 dues to high compile times causing timeouts (PR38897).
Checking in to unblock failing builds. Patch available for post-commit review and re-revert once resolved.
Working on a smaller reproducer for PR38897.

Diff Detail

Event Timeline

asbirlea created this revision.Sep 10 2018, 4:48 PM
Herald added subscribers: jlebar, sanjoy. · View Herald TranscriptSep 10 2018, 4:48 PM
Harbormaster completed remote builds in B22444: Diff 164769.Sep 10 2018, 4:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 10 2018, 4:48 PM
Closed by commit rL341883: [InstCombine] Partially revert rL341674 due to PR38897. (authored by asbirlea). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Transforms/
InstCombine/
43 lines
test/
Transforms/
InstCombine/
18 lines
8 lines
32 lines
42 lines
2 lines

Diff 164769

lib/Transforms/InstCombine/InstCombineSelect.cpp

Show First 20 Lines • Show All 1,821 Lines • ▼ Show 20 Lines if (SelectPatternResult::isMinOrMax(SPF)) {
if (!IsCastNeeded) if (!IsCastNeeded)
return replaceInstUsesWith(SI, NewSI); return replaceInstUsesWith(SI, NewSI);
Value *NewCast = Builder.CreateCast(CastOp, NewSI, SelType); Value *NewCast = Builder.CreateCast(CastOp, NewSI, SelType);
return replaceInstUsesWith(SI, NewCast); return replaceInstUsesWith(SI, NewCast);
} }
// MAX(~a, ~b) -> ~MIN(a, b) // MAX(~a, ~b) -> ~MIN(a, b)
// MAX(~a, C) -> ~MIN(a, ~C)
// MIN(~a, ~b) -> ~MAX(a, b) // MIN(~a, ~b) -> ~MAX(a, b)
// MIN(~a, C) -> ~MAX(a, ~C) Value *A, *B;
auto moveNotAfterMinMax = [&](Value *X, Value *Y, if (match(LHS, m_Not(m_Value(A))) && match(RHS, m_Not(m_Value(B))) &&
bool Swapped) -> Instruction * { (!LHS->hasNUsesOrMore(3) || !RHS->hasNUsesOrMore(3))) {
Value *A; CmpInst::Predicate InvertedPred = getInverseMinMaxPred(SPF);
if (match(X, m_Not(m_Value(A))) && !X->hasNUsesOrMore(3) && Value *InvertedCmp = Builder.CreateICmp(InvertedPred, A, B);
// Passing false to only consider m_Not and constants. Value *NewSel = Builder.CreateSelect(InvertedCmp, A, B);
IsFreeToInvert(Y, false)) { return BinaryOperator::CreateNot(NewSel);
Value *B = Builder.CreateNot(Y);
Value *NewMinMax = createMinMax(Builder, getInverseMinMaxFlavor(SPF),
A, B);
// Copy the profile metadata.
if (MDNode *MD = SI.getMetadata(LLVMContext::MD_prof)) {
cast<SelectInst>(NewMinMax)->setMetadata(LLVMContext::MD_prof, MD);
// Swap the metadata if the operands are swapped.
if (Swapped) {
assert(X == SI.getFalseValue() && Y == SI.getTrueValue() &&
"Unexpected operands.");
cast<SelectInst>(NewMinMax)->swapProfMetadata();
} else {
assert(X == SI.getTrueValue() && Y == SI.getFalseValue() &&
"Unexpected operands.");
}
}
return BinaryOperator::CreateNot(NewMinMax);
} }
return nullptr;
};
if (Instruction *I = moveNotAfterMinMax(LHS, RHS, /*Swapped*/false))
return I;
if (Instruction *I = moveNotAfterMinMax(RHS, LHS, /*Swapped*/true))
return I;
if (Instruction *I = factorizeMinMaxTree(SPF, LHS, RHS, Builder)) if (Instruction *I = factorizeMinMaxTree(SPF, LHS, RHS, Builder))
return I; return I;
} }
if (SPF) { if (SPF) {
// MAX(MAX(a, b), a) -> MAX(a, b) // MAX(MAX(a, b), a) -> MAX(a, b)
// MIN(MIN(a, b), a) -> MIN(a, b) // MIN(MIN(a, b), a) -> MIN(a, b)
// MAX(MIN(a, b), a) -> a // MAX(MIN(a, b), a) -> a
▲ Show 20 Lines • Show All 182 Lines • Show Last 20 Lines

test/Transforms/InstCombine/max-of-nots.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -S -instcombine < %s | FileCheck %s ; RUN: opt -S -instcombine < %s | FileCheck %s
define <2 x i32> @umin_of_nots(<2 x i32> %x, <2 x i32> %y) { define <2 x i32> @umin_of_nots(<2 x i32> %x, <2 x i32> %y) {
; CHECK-LABEL: @umin_of_nots( ; CHECK-LABEL: @umin_of_nots(
; CHECK-NEXT: [[TMP1:%.*]] = icmp ult <2 x i32> [[Y:%.*]], [[X:%.*]] ; CHECK-NEXT: [[TMP1:%.*]] = icmp ugt <2 x i32> [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select <2 x i1> [[TMP1]], <2 x i32> [[X]], <2 x i32> [[Y]] ; CHECK-NEXT: [[TMP2:%.*]] = select <2 x i1> [[TMP1]], <2 x i32> [[X]], <2 x i32> [[Y]]
; CHECK-NEXT: [[MIN:%.*]] = xor <2 x i32> [[TMP2]], <i32 -1, i32 -1> ; CHECK-NEXT: [[MIN:%.*]] = xor <2 x i32> [[TMP2]], <i32 -1, i32 -1>
; CHECK-NEXT: ret <2 x i32> [[MIN]] ; CHECK-NEXT: ret <2 x i32> [[MIN]]
; ;
%notx = xor <2 x i32> %x, <i32 -1, i32 -1> %notx = xor <2 x i32> %x, <i32 -1, i32 -1>
%noty = xor <2 x i32> %y, <i32 -1, i32 -1> %noty = xor <2 x i32> %y, <i32 -1, i32 -1>
%cmp = icmp ult <2 x i32> %notx, %noty %cmp = icmp ult <2 x i32> %notx, %noty
%min = select <2 x i1> %cmp, <2 x i32> %notx, <2 x i32> %noty %min = select <2 x i1> %cmp, <2 x i32> %notx, <2 x i32> %noty
ret <2 x i32> %min ret <2 x i32> %min
} }
define <2 x i32> @smin_of_nots(<2 x i32> %x, <2 x i32> %y) { define <2 x i32> @smin_of_nots(<2 x i32> %x, <2 x i32> %y) {
; CHECK-LABEL: @smin_of_nots( ; CHECK-LABEL: @smin_of_nots(
; CHECK-NEXT: [[TMP1:%.*]] = icmp slt <2 x i32> [[Y:%.*]], [[X:%.*]] ; CHECK-NEXT: [[TMP1:%.*]] = icmp sgt <2 x i32> [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select <2 x i1> [[TMP1]], <2 x i32> [[X]], <2 x i32> [[Y]] ; CHECK-NEXT: [[TMP2:%.*]] = select <2 x i1> [[TMP1]], <2 x i32> [[X]], <2 x i32> [[Y]]
; CHECK-NEXT: [[MIN:%.*]] = xor <2 x i32> [[TMP2]], <i32 -1, i32 -1> ; CHECK-NEXT: [[MIN:%.*]] = xor <2 x i32> [[TMP2]], <i32 -1, i32 -1>
; CHECK-NEXT: ret <2 x i32> [[MIN]] ; CHECK-NEXT: ret <2 x i32> [[MIN]]
; ;
%notx = xor <2 x i32> %x, <i32 -1, i32 -1> %notx = xor <2 x i32> %x, <i32 -1, i32 -1>
%noty = xor <2 x i32> %y, <i32 -1, i32 -1> %noty = xor <2 x i32> %y, <i32 -1, i32 -1>
%cmp = icmp sle <2 x i32> %notx, %noty %cmp = icmp sle <2 x i32> %notx, %noty
%min = select <2 x i1> %cmp, <2 x i32> %notx, <2 x i32> %noty %min = select <2 x i1> %cmp, <2 x i32> %notx, <2 x i32> %noty
ret <2 x i32> %min ret <2 x i32> %min
} }
define i32 @compute_min_2(i32 %x, i32 %y) { define i32 @compute_min_2(i32 %x, i32 %y) {
; CHECK-LABEL: @compute_min_2( ; CHECK-LABEL: @compute_min_2(
; CHECK-NEXT: [[TMP1:%.*]] = icmp sgt i32 [[Y:%.*]], [[X:%.*]] ; CHECK-NEXT: [[TMP1:%.*]] = icmp slt i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 [[Y]] ; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 [[Y]]
; CHECK-NEXT: ret i32 [[TMP2]] ; CHECK-NEXT: ret i32 [[TMP2]]
; ;
%not_x = sub i32 -1, %x %not_x = sub i32 -1, %x
%not_y = sub i32 -1, %y %not_y = sub i32 -1, %y
%cmp = icmp sgt i32 %not_x, %not_y %cmp = icmp sgt i32 %not_x, %not_y
%not_min = select i1 %cmp, i32 %not_x, i32 %not_y %not_min = select i1 %cmp, i32 %not_x, i32 %not_y
%min = sub i32 -1, %not_min %min = sub i32 -1, %not_min
ret i32 %min ret i32 %min
} }
declare void @extra_use(i8) declare void @extra_use(i8)
define i8 @umin_not_1_extra_use(i8 %x, i8 %y) { define i8 @umin_not_1_extra_use(i8 %x, i8 %y) {
; CHECK-LABEL: @umin_not_1_extra_use( ; CHECK-LABEL: @umin_not_1_extra_use(
; CHECK-NEXT: [[NX:%.*]] = xor i8 [[X:%.*]], -1 ; CHECK-NEXT: [[NX:%.*]] = xor i8 [[X:%.*]], -1
; CHECK-NEXT: [[TMP1:%.*]] = icmp ult i8 [[X]], [[Y:%.*]] ; CHECK-NEXT: [[TMP1:%.*]] = icmp ugt i8 [[X]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i8 [[Y]], i8 [[X]] ; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i8 [[X]], i8 [[Y]]
; CHECK-NEXT: [[MINXY:%.*]] = xor i8 [[TMP2]], -1 ; CHECK-NEXT: [[MINXY:%.*]] = xor i8 [[TMP2]], -1
; CHECK-NEXT: call void @extra_use(i8 [[NX]]) ; CHECK-NEXT: call void @extra_use(i8 [[NX]])
; CHECK-NEXT: ret i8 [[MINXY]] ; CHECK-NEXT: ret i8 [[MINXY]]
; ;
%nx = xor i8 %x, -1 %nx = xor i8 %x, -1
%ny = xor i8 %y, -1 %ny = xor i8 %y, -1
%cmpxy = icmp ult i8 %nx, %ny %cmpxy = icmp ult i8 %nx, %ny
%minxy = select i1 %cmpxy, i8 %nx, i8 %ny %minxy = select i1 %cmpxy, i8 %nx, i8 %ny
Show All 19 Lines;
call void @extra_use(i8 %ny) call void @extra_use(i8 %ny)
ret i8 %minxy ret i8 %minxy
} }
; PR35834 - https://bugs.llvm.org/show_bug.cgi?id=35834 ; PR35834 - https://bugs.llvm.org/show_bug.cgi?id=35834
define i8 @umin3_not(i8 %x, i8 %y, i8 %z) { define i8 @umin3_not(i8 %x, i8 %y, i8 %z) {
; CHECK-LABEL: @umin3_not( ; CHECK-LABEL: @umin3_not(
; CHECK-NEXT: [[TMP1:%.*]] = icmp ult i8 [[Z:%.*]], [[X:%.*]] ; CHECK-NEXT: [[TMP1:%.*]] = icmp ugt i8 [[X:%.*]], [[Z:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i8 [[X]], i8 [[Z]] ; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i8 [[X]], i8 [[Z]]
; CHECK-NEXT: [[TMP3:%.*]] = icmp ugt i8 [[TMP2]], [[Y:%.*]] ; CHECK-NEXT: [[TMP3:%.*]] = icmp ugt i8 [[TMP2]], [[Y:%.*]]
; CHECK-NEXT: [[R_V:%.*]] = select i1 [[TMP3]], i8 [[TMP2]], i8 [[Y]] ; CHECK-NEXT: [[R_V:%.*]] = select i1 [[TMP3]], i8 [[TMP2]], i8 [[Y]]
; CHECK-NEXT: [[R:%.*]] = xor i8 [[R_V]], -1 ; CHECK-NEXT: [[R:%.*]] = xor i8 [[R_V]], -1
; CHECK-NEXT: ret i8 [[R]] ; CHECK-NEXT: ret i8 [[R]]
; ;
%nx = xor i8 %x, -1 %nx = xor i8 %x, -1
%ny = xor i8 %y, -1 %ny = xor i8 %y, -1
%nz = xor i8 %z, -1 %nz = xor i8 %z, -1
%cmpyx = icmp ult i8 %y, %x %cmpyx = icmp ult i8 %y, %x
%cmpxz = icmp ult i8 %nx, %nz %cmpxz = icmp ult i8 %nx, %nz
%minxz = select i1 %cmpxz, i8 %nx, i8 %nz %minxz = select i1 %cmpxz, i8 %nx, i8 %nz
%cmpyz = icmp ult i8 %ny, %nz %cmpyz = icmp ult i8 %ny, %nz
%minyz = select i1 %cmpyz, i8 %ny, i8 %nz %minyz = select i1 %cmpyz, i8 %ny, i8 %nz
%r = select i1 %cmpyx, i8 %minxz, i8 %minyz %r = select i1 %cmpyx, i8 %minxz, i8 %minyz
ret i8 %r ret i8 %r
} }
; PR35875 - https://bugs.llvm.org/show_bug.cgi?id=35875 ; PR35875 - https://bugs.llvm.org/show_bug.cgi?id=35875
define i8 @umin3_not_more_uses(i8 %x, i8 %y, i8 %z) { define i8 @umin3_not_more_uses(i8 %x, i8 %y, i8 %z) {
; CHECK-LABEL: @umin3_not_more_uses( ; CHECK-LABEL: @umin3_not_more_uses(
; CHECK-NEXT: [[NX:%.*]] = xor i8 [[X:%.*]], -1 ; CHECK-NEXT: [[NX:%.*]] = xor i8 [[X:%.*]], -1
; CHECK-NEXT: [[NY:%.*]] = xor i8 [[Y:%.*]], -1 ; CHECK-NEXT: [[NY:%.*]] = xor i8 [[Y:%.*]], -1
; CHECK-NEXT: [[TMP1:%.*]] = icmp ult i8 [[X]], [[Z:%.*]] ; CHECK-NEXT: [[TMP1:%.*]] = icmp ugt i8 [[X]], [[Z:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i8 [[Z]], i8 [[X]] ; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i8 [[X]], i8 [[Z]]
; CHECK-NEXT: [[TMP3:%.*]] = icmp ugt i8 [[TMP2]], [[Y]] ; CHECK-NEXT: [[TMP3:%.*]] = icmp ugt i8 [[TMP2]], [[Y]]
; CHECK-NEXT: [[TMP4:%.*]] = select i1 [[TMP3]], i8 [[TMP2]], i8 [[Y]] ; CHECK-NEXT: [[TMP4:%.*]] = select i1 [[TMP3]], i8 [[TMP2]], i8 [[Y]]
; CHECK-NEXT: [[R:%.*]] = xor i8 [[TMP4]], -1 ; CHECK-NEXT: [[R:%.*]] = xor i8 [[TMP4]], -1
; CHECK-NEXT: call void @extra_use(i8 [[NX]]) ; CHECK-NEXT: call void @extra_use(i8 [[NX]])
; CHECK-NEXT: call void @extra_use(i8 [[NY]]) ; CHECK-NEXT: call void @extra_use(i8 [[NY]])
; CHECK-NEXT: ret i8 [[R]] ; CHECK-NEXT: ret i8 [[R]]
; ;
%nx = xor i8 %x, -1 %nx = xor i8 %x, -1
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines;
call void @use8(i8 %xmin) call void @use8(i8 %xmin)
call void @use8(i8 %ymin) call void @use8(i8 %ymin)
call void @use8(i8 %zmin) call void @use8(i8 %zmin)
ret void ret void
} }
define i32 @compute_min_3(i32 %x, i32 %y, i32 %z) { define i32 @compute_min_3(i32 %x, i32 %y, i32 %z) {
; CHECK-LABEL: @compute_min_3( ; CHECK-LABEL: @compute_min_3(
; CHECK-NEXT: [[TMP1:%.*]] = icmp sgt i32 [[Y:%.*]], [[X:%.*]] ; CHECK-NEXT: [[TMP1:%.*]] = icmp slt i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 [[Y]] ; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 [[Y]]
; CHECK-NEXT: [[TMP3:%.*]] = icmp slt i32 [[TMP2]], [[Z:%.*]] ; CHECK-NEXT: [[TMP3:%.*]] = icmp slt i32 [[TMP2]], [[Z:%.*]]
; CHECK-NEXT: [[TMP4:%.*]] = select i1 [[TMP3]], i32 [[TMP2]], i32 [[Z]] ; CHECK-NEXT: [[TMP4:%.*]] = select i1 [[TMP3]], i32 [[TMP2]], i32 [[Z]]
; CHECK-NEXT: ret i32 [[TMP4]] ; CHECK-NEXT: ret i32 [[TMP4]]
; ;
%not_x = sub i32 -1, %x %not_x = sub i32 -1, %x
%not_y = sub i32 -1, %y %not_y = sub i32 -1, %y
%not_z = sub i32 -1, %z %not_z = sub i32 -1, %z
▲ Show 20 Lines • Show All 186 Lines • Show Last 20 Lines

test/Transforms/InstCombine/select.ll

Show First 20 Lines • Show All 1,323 Lines • ▼ Show 20 Lines
; CHECK-NEXT: ret i32 [[SEL]] ; CHECK-NEXT: ret i32 [[SEL]]
; ;
%cmp = icmp eq i32 %x, 2147483647 %cmp = icmp eq i32 %x, 2147483647
%add = add nsw i32 %x, 1 %add = add nsw i32 %x, 1
%sel = select i1 %cmp, i32 -2147483648, i32 %add %sel = select i1 %cmp, i32 -2147483648, i32 %add
ret i32 %sel ret i32 %sel
} }
; max(max(~a, -1), -1) --> ~min(a, 0) ; max(max(~a, -1), -1) --> max(~a, -1)
define i32 @PR27137(i32 %a) { define i32 @PR27137(i32 %a) {
; CHECK-LABEL: @PR27137( ; CHECK-LABEL: @PR27137(
; CHECK-NEXT: [[TMP1:%.*]] = icmp slt i32 [[A:%.*]], 0 ; CHECK-NEXT: [[NOT_A:%.*]] = xor i32 [[A:%.*]], -1
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[A]], i32 0 ; CHECK-NEXT: [[TMP1:%.*]] = icmp sgt i32 [[NOT_A]], -1
; CHECK-NEXT: [[S1:%.*]] = xor i32 [[TMP2]], -1 ; CHECK-NEXT: [[S1:%.*]] = select i1 [[TMP1]], i32 [[NOT_A]], i32 -1
; CHECK-NEXT: ret i32 [[S1]] ; CHECK-NEXT: ret i32 [[S1]]
; ;
%not_a = xor i32 %a, -1 %not_a = xor i32 %a, -1
%c0 = icmp slt i32 %a, 0 %c0 = icmp slt i32 %a, 0
%s0 = select i1 %c0, i32 %not_a, i32 -1 %s0 = select i1 %c0, i32 %not_a, i32 -1
%c1 = icmp sgt i32 %s0, -1 %c1 = icmp sgt i32 %s0, -1
%s1 = select i1 %c1, i32 %s0, i32 -1 %s1 = select i1 %c1, i32 %s0, i32 -1
ret i32 %s1 ret i32 %s1
▲ Show 20 Lines • Show All 160 Lines • Show Last 20 Lines

test/Transforms/InstCombine/select_meta.ll

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Lines
; ;
%cmp = icmp slt i32 %x, 36 %cmp = icmp slt i32 %x, 36
%cond = select i1 %cmp, i32 36, i32 %x, !prof !1 %cond = select i1 %cmp, i32 36, i32 %x, !prof !1
%cmp3 = icmp slt i32 %cond, 75 %cmp3 = icmp slt i32 %cond, 75
%retval = select i1 %cmp3, i32 75, i32 %cond, !prof !2 %retval = select i1 %cmp3, i32 75, i32 %cond, !prof !2
ret i32 %retval ret i32 %retval
} }
; The xor is moved after the select. The metadata remains the same because the select operands are not swapped only inverted. ; The compare should change, but the metadata remains the same because the select operands are not swapped.
define i32 @smin1(i32 %x) { define i32 @smin1(i32 %x) {
; CHECK-LABEL: @smin1( ; CHECK-LABEL: @smin1(
; CHECK-NEXT: [[TMP1:%.*]] = icmp sgt i32 [[X:%.*]], 0 ; CHECK-NEXT: [[NOT_X:%.*]] = xor i32 %x, -1
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 0, !prof ![[$MD1]] ; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[NOT_X]], -1
; CHECK-NEXT: [[SEL:%.*]] = xor i32 [[TMP2]], -1 ; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], i32 [[NOT_X]], i32 -1, !prof ![[$MD1]]
; CHECK-NEXT: ret i32 [[SEL]] ; CHECK-NEXT: ret i32 [[SEL]]
; ;
%not_x = xor i32 %x, -1 %not_x = xor i32 %x, -1
%cmp = icmp sgt i32 %x, 0 %cmp = icmp sgt i32 %x, 0
%sel = select i1 %cmp, i32 %not_x, i32 -1, !prof !1 %sel = select i1 %cmp, i32 %not_x, i32 -1, !prof !1
ret i32 %sel ret i32 %sel
} }
; The compare should change, and the metadata is swapped because the select operands are swapped and inverted. ; The compare should change, and the metadata is swapped because the select operands are swapped.
define i32 @smin2(i32 %x) { define i32 @smin2(i32 %x) {
; CHECK-LABEL: @smin2( ; CHECK-LABEL: @smin2(
; CHECK-NEXT: [[TMP1:%.*]] = icmp sgt i32 [[X:%.*]], 0 ; CHECK-NEXT: [[NOT_X:%.*]] = xor i32 %x, -1
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 0, !prof ![[$MD3]] ; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[NOT_X]], -1
; CHECK-NEXT: [[SEL:%.*]] = xor i32 [[TMP2]], -1 ; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], i32 [[NOT_X]], i32 -1, !prof ![[$MD3]]
; CHECK-NEXT: ret i32 [[SEL]] ; CHECK-NEXT: ret i32 [[SEL]]
; ;
%not_x = xor i32 %x, -1 %not_x = xor i32 %x, -1
%cmp = icmp slt i32 %x, 0 %cmp = icmp slt i32 %x, 0
%sel = select i1 %cmp, i32 -1, i32 %not_x, !prof !1 %sel = select i1 %cmp, i32 -1, i32 %not_x, !prof !1
ret i32 %sel ret i32 %sel
} }
; The xor is moved after the select. The metadata remains the same because the select operands are not swapped only inverted. ; The compare should change, but the metadata remains the same because the select operands are not swapped.
define i32 @smax1(i32 %x) { define i32 @smax1(i32 %x) {
; CHECK-LABEL: @smax1( ; CHECK-LABEL: @smax1(
; CHECK-NEXT: [[TMP1:%.*]] = icmp slt i32 [[X:%.*]], 0 ; CHECK-NEXT: [[NOT_X:%.*]] = xor i32 %x, -1
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 0, !prof ![[$MD1]] ; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i32 [[NOT_X]], -1
; CHECK-NEXT: [[SEL:%.*]] = xor i32 [[TMP2]], -1 ; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], i32 [[NOT_X]], i32 -1, !prof ![[$MD1]]
; CHECK-NEXT: ret i32 [[SEL]] ; CHECK-NEXT: ret i32 [[SEL]]
; ;
%not_x = xor i32 %x, -1 %not_x = xor i32 %x, -1
%cmp = icmp slt i32 %x, 0 %cmp = icmp slt i32 %x, 0
%sel = select i1 %cmp, i32 %not_x, i32 -1, !prof !1 %sel = select i1 %cmp, i32 %not_x, i32 -1, !prof !1
ret i32 %sel ret i32 %sel
} }
; The compare should change, and the metadata is swapped because the select operands are swapped and inverted. ; The compare should change, and the metadata is swapped because the select operands are swapped.
define i32 @smax2(i32 %x) { define i32 @smax2(i32 %x) {
; CHECK-LABEL: @smax2( ; CHECK-LABEL: @smax2(
; CHECK-NEXT: [[TMP1:%.*]] = icmp slt i32 [[X:%.*]], 0 ; CHECK-NEXT: [[NOT_X:%.*]] = xor i32 %x, -1
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 0, !prof ![[$MD3]] ; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i32 [[NOT_X]], -1
; CHECK-NEXT: [[SEL:%.*]] = xor i32 [[TMP2]], -1 ; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], i32 [[NOT_X]], i32 -1, !prof ![[$MD3]]
; CHECK-NEXT: ret i32 [[SEL]] ; CHECK-NEXT: ret i32 [[SEL]]
; ;
%not_x = xor i32 %x, -1 %not_x = xor i32 %x, -1
%cmp = icmp sgt i32 %x, 0 %cmp = icmp sgt i32 %x, 0
%sel = select i1 %cmp, i32 -1, i32 %not_x, !prof !1 %sel = select i1 %cmp, i32 -1, i32 %not_x, !prof !1
ret i32 %sel ret i32 %sel
} }
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines

test/Transforms/InstCombine/sub.ll

Show First 20 Lines • Show All 1,054 Lines • ▼ Show 20 Lines;
%C = shl <2 x i32> %B, <i32 1, i32 1> %C = shl <2 x i32> %B, <i32 1, i32 1>
%D = sub <2 x i32> <i32 2, i32 2>, %C %D = sub <2 x i32> <i32 2, i32 2>, %C
ret <2 x i32> %D ret <2 x i32> %D
} }
; FIXME: Transform (neg (max ~X, C)) -> ((min X, ~C) + 1). Same for min. ; FIXME: Transform (neg (max ~X, C)) -> ((min X, ~C) + 1). Same for min.
define i32 @test64(i32 %x) { define i32 @test64(i32 %x) {
; CHECK-LABEL: @test64( ; CHECK-LABEL: @test64(
; CHECK-NEXT: [[TMP1:%.*]] = icmp slt i32 [[X:%.*]], 255 ; CHECK-NEXT: [[TMP1:%.*]] = xor i32 [[X:%.*]], -1
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 255 ; CHECK-NEXT: [[TMP2:%.*]] = icmp sgt i32 [[TMP1]], -256
; CHECK-NEXT: [[RES:%.*]] = add i32 [[TMP2]], 1 ; CHECK-NEXT: [[TMP3:%.*]] = select i1 [[TMP2]], i32 [[TMP1]], i32 -256
; CHECK-NEXT: [[RES:%.*]] = sub i32 0, [[TMP3]]
; CHECK-NEXT: ret i32 [[RES]] ; CHECK-NEXT: ret i32 [[RES]]
; ;
%1 = xor i32 %x, -1 %1 = xor i32 %x, -1
%2 = icmp sgt i32 %1, -256 %2 = icmp sgt i32 %1, -256
%3 = select i1 %2, i32 %1, i32 -256 %3 = select i1 %2, i32 %1, i32 -256
%res = sub i32 0, %3 %res = sub i32 0, %3
ret i32 %res ret i32 %res
} }
define i32 @test65(i32 %x) { define i32 @test65(i32 %x) {
; CHECK-LABEL: @test65( ; CHECK-LABEL: @test65(
; CHECK-NEXT: [[TMP1:%.*]] = icmp sgt i32 [[X:%.*]], -256 ; CHECK-NEXT: [[TMP1:%.*]] = xor i32 [[X:%.*]], -1
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 -256 ; CHECK-NEXT: [[TMP2:%.*]] = icmp slt i32 [[TMP1]], 255
; CHECK-NEXT: [[RES:%.*]] = add i32 [[TMP2]], 1 ; CHECK-NEXT: [[TMP3:%.*]] = select i1 [[TMP2]], i32 [[TMP1]], i32 255
; CHECK-NEXT: [[RES:%.*]] = sub i32 0, [[TMP3]]
; CHECK-NEXT: ret i32 [[RES]] ; CHECK-NEXT: ret i32 [[RES]]
; ;
%1 = xor i32 %x, -1 %1 = xor i32 %x, -1
%2 = icmp slt i32 %1, 255 %2 = icmp slt i32 %1, 255
%3 = select i1 %2, i32 %1, i32 255 %3 = select i1 %2, i32 %1, i32 255
%res = sub i32 0, %3 %res = sub i32 0, %3
ret i32 %res ret i32 %res
} }
define i32 @test66(i32 %x) { define i32 @test66(i32 %x) {
; CHECK-LABEL: @test66( ; CHECK-LABEL: @test66(
; CHECK-NEXT: [[TMP1:%.*]] = icmp ult i32 [[X:%.*]], -101 ; CHECK-NEXT: [[TMP1:%.*]] = xor i32 [[X:%.*]], -1
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 -101 ; CHECK-NEXT: [[TMP2:%.*]] = icmp ugt i32 [[TMP1]], 100
; CHECK-NEXT: [[RES:%.*]] = add i32 [[TMP2]], 1 ; CHECK-NEXT: [[TMP3:%.*]] = select i1 [[TMP2]], i32 [[TMP1]], i32 100
; CHECK-NEXT: [[RES:%.*]] = sub i32 0, [[TMP3]]
; CHECK-NEXT: ret i32 [[RES]] ; CHECK-NEXT: ret i32 [[RES]]
; ;
%1 = xor i32 %x, -1 %1 = xor i32 %x, -1
%2 = icmp ugt i32 %1, 100 %2 = icmp ugt i32 %1, 100
%3 = select i1 %2, i32 %1, i32 100 %3 = select i1 %2, i32 %1, i32 100
%res = sub i32 0, %3 %res = sub i32 0, %3
ret i32 %res ret i32 %res
} }
define i32 @test67(i32 %x) { define i32 @test67(i32 %x) {
; CHECK-LABEL: @test67( ; CHECK-LABEL: @test67(
; CHECK-NEXT: [[TMP1:%.*]] = icmp ugt i32 [[X:%.*]], 100 ; CHECK-NEXT: [[TMP1:%.*]] = xor i32 [[X:%.*]], -1
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 100 ; CHECK-NEXT: [[TMP2:%.*]] = icmp ult i32 [[TMP1]], -101
; CHECK-NEXT: [[RES:%.*]] = add i32 [[TMP2]], 1 ; CHECK-NEXT: [[TMP3:%.*]] = select i1 [[TMP2]], i32 [[TMP1]], i32 -101
; CHECK-NEXT: [[RES:%.*]] = sub i32 0, [[TMP3]]
; CHECK-NEXT: ret i32 [[RES]] ; CHECK-NEXT: ret i32 [[RES]]
; ;
%1 = xor i32 %x, -1 %1 = xor i32 %x, -1
%2 = icmp ult i32 %1, -101 %2 = icmp ult i32 %1, -101
%3 = select i1 %2, i32 %1, i32 -101 %3 = select i1 %2, i32 %1, i32 -101
%res = sub i32 0, %3 %res = sub i32 0, %3
ret i32 %res ret i32 %res
} }
; Check splat vectors too ; Check splat vectors too
define <2 x i32> @test68(<2 x i32> %x) { define <2 x i32> @test68(<2 x i32> %x) {
; CHECK-LABEL: @test68( ; CHECK-LABEL: @test68(
; CHECK-NEXT: [[TMP1:%.*]] = icmp slt <2 x i32> [[X:%.*]], <i32 255, i32 255> ; CHECK-NEXT: [[TMP1:%.*]] = xor <2 x i32> [[X:%.*]], <i32 -1, i32 -1>
; CHECK-NEXT: [[TMP2:%.*]] = select <2 x i1> [[TMP1]], <2 x i32> [[X]], <2 x i32> <i32 255, i32 255> ; CHECK-NEXT: [[TMP2:%.*]] = icmp sgt <2 x i32> [[TMP1]], <i32 -256, i32 -256>
; CHECK-NEXT: [[RES:%.*]] = add <2 x i32> [[TMP2]], <i32 1, i32 1> ; CHECK-NEXT: [[TMP3:%.*]] = select <2 x i1> [[TMP2]], <2 x i32> [[TMP1]], <2 x i32> <i32 -256, i32 -256>
; CHECK-NEXT: [[RES:%.*]] = sub <2 x i32> zeroinitializer, [[TMP3]]
; CHECK-NEXT: ret <2 x i32> [[RES]] ; CHECK-NEXT: ret <2 x i32> [[RES]]
; ;
%1 = xor <2 x i32> %x, <i32 -1, i32 -1> %1 = xor <2 x i32> %x, <i32 -1, i32 -1>
%2 = icmp sgt <2 x i32> %1, <i32 -256, i32 -256> %2 = icmp sgt <2 x i32> %1, <i32 -256, i32 -256>
%3 = select <2 x i1> %2, <2 x i32> %1, <2 x i32> <i32 -256, i32 -256> %3 = select <2 x i1> %2, <2 x i32> %1, <2 x i32> <i32 -256, i32 -256>
%res = sub <2 x i32> zeroinitializer, %3 %res = sub <2 x i32> zeroinitializer, %3
ret <2 x i32> %res ret <2 x i32> %res
} }
; And non-splat constant vectors. ; And non-splat constant vectors.
define <2 x i32> @test69(<2 x i32> %x) { define <2 x i32> @test69(<2 x i32> %x) {
; CHECK-LABEL: @test69( ; CHECK-LABEL: @test69(
; CHECK-NEXT: [[TMP1:%.*]] = icmp slt <2 x i32> [[X:%.*]], <i32 255, i32 127> ; CHECK-NEXT: [[TMP1:%.*]] = xor <2 x i32> [[X:%.*]], <i32 -1, i32 -1>
; CHECK-NEXT: [[TMP2:%.*]] = select <2 x i1> [[TMP1]], <2 x i32> [[X]], <2 x i32> <i32 255, i32 127> ; CHECK-NEXT: [[TMP2:%.*]] = icmp sgt <2 x i32> [[TMP1]], <i32 -256, i32 -128>
; CHECK-NEXT: [[RES:%.*]] = add <2 x i32> [[TMP2]], <i32 1, i32 1> ; CHECK-NEXT: [[TMP3:%.*]] = select <2 x i1> [[TMP2]], <2 x i32> [[TMP1]], <2 x i32> <i32 -256, i32 -128>
; CHECK-NEXT: [[RES:%.*]] = sub <2 x i32> zeroinitializer, [[TMP3]]
; CHECK-NEXT: ret <2 x i32> [[RES]] ; CHECK-NEXT: ret <2 x i32> [[RES]]
; ;
%1 = xor <2 x i32> %x, <i32 -1, i32 -1> %1 = xor <2 x i32> %x, <i32 -1, i32 -1>
%2 = icmp sgt <2 x i32> %1, <i32 -256, i32 -128> %2 = icmp sgt <2 x i32> %1, <i32 -256, i32 -128>
%3 = select <2 x i1> %2, <2 x i32> %1, <2 x i32> <i32 -256, i32 -128> %3 = select <2 x i1> %2, <2 x i32> %1, <2 x i32> <i32 -256, i32 -128>
%res = sub <2 x i32> zeroinitializer, %3 %res = sub <2 x i32> zeroinitializer, %3
ret <2 x i32> %res ret <2 x i32> %res
} }

test/Transforms/InstCombine/xor.ll

Show First 20 Lines • Show All 751 Lines • ▼ Show 20 Lines;
%cmp1 = icmp ult i32 %z, %notx %cmp1 = icmp ult i32 %z, %notx
%umin = select i1 %cmp1, i32 %z, i32 %notx %umin = select i1 %cmp1, i32 %z, i32 %notx
%res = xor i32 %umin, -1 %res = xor i32 %umin, -1
ret i32 %res ret i32 %res
} }
define i32 @test45(i32 %x, i32 %y) { define i32 @test45(i32 %x, i32 %y) {
; CHECK-LABEL: @test45( ; CHECK-LABEL: @test45(
; CHECK-NEXT: [[TMP1:%.*]] = icmp ult i32 [[X:%.*]], [[Y:%.*]] ; CHECK-NEXT: [[TMP1:%.*]] = icmp ugt i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[Y]], i32 [[X]] ; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[Y]], i32 [[X]]
; CHECK-NEXT: ret i32 [[TMP2]] ; CHECK-NEXT: ret i32 [[TMP2]]
; ;
%z = xor i32 %y, -1 %z = xor i32 %y, -1
%notx = xor i32 %x, -1 %notx = xor i32 %x, -1
%cmp1 = icmp ult i32 %z, %notx %cmp1 = icmp ult i32 %z, %notx
%umin = select i1 %cmp1, i32 %z, i32 %notx %umin = select i1 %cmp1, i32 %z, i32 %notx
%res = xor i32 %umin, -1 %res = xor i32 %umin, -1
Show All 36 Lines