This is an archive of the discontinued LLVM Phabricator instance.

NFC: bit.h don't warn on strict aliasing for GCC <= 7.1
ClosedPublic

Authored by jfb on Sep 10 2018, 10:51 AM.

Diff Detail

Event Timeline

jfb created this revision.Sep 10 2018, 10:51 AM
jfb added a comment.Sep 10 2018, 10:52 AM

I tried this out with a few GCC and clang versions to make sure the pragma was supported by both. Seems fine.

jfb accepted this revision.Sep 10 2018, 12:57 PM

Assuming this is good to go since it's a build breakage. Happy to do follow-ups if you have post-commit comments.

This revision is now accepted and ready to land.Sep 10 2018, 12:57 PM
This revision was automatically updated to reflect the committed changes.
xbolva00 added a subscriber: xbolva00.EditedSep 11 2018, 11:38 PM

Please check also https://reviews.llvm.org/rL339521, maybe we can apply that workaround for GCC here too :)