This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Avoid REVERSE on empty list
ClosedPublic

Authored by svenvh on Sep 7 2018, 9:23 AM.

Details

Summary

If required_libs happens to remain empty, CMake would bail out with:

list sub-command REVERSE requires list to be present.

Fix by ensuring we do not attempt to reverse an empty list.

Diff Detail

Repository
rL LLVM

Event Timeline

svenvh created this revision.Sep 7 2018, 9:23 AM
joey accepted this revision.Sep 25 2018, 3:26 AM
joey added a subscriber: joey.

LGTM

This revision is now accepted and ready to land.Sep 25 2018, 3:26 AM
This revision was automatically updated to reflect the committed changes.