Page MenuHomePhabricator

[OpenCL] Allow blocks to capture arrays in OpenCL
ClosedPublic

Authored by sidorovd on Sep 6 2018, 1:30 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sidorovd created this revision.Sep 6 2018, 1:30 AM

Previously this patch was reviewed here: https://reviews.llvm.org/D26794 . I wasn't able to update it, so I created a new one with the comments applied.

Anastasia accepted this revision.Sep 6 2018, 7:10 AM

LGTM! There is a small comment that can be addressed before the final commit. Thanks!

lib/Sema/SemaExpr.cpp
14627 ↗(On Diff #164159)

It would be good to add spec reference here.

This revision is now accepted and ready to land.Sep 6 2018, 7:10 AM
sidorovd updated this revision to Diff 164214.Sep 6 2018, 7:40 AM

Reference to the Spec was added

sidorovd marked an inline comment as done.Sep 6 2018, 7:40 AM
This revision was automatically updated to reflect the committed changes.