Page MenuHomePhabricator

[Bindings][Go] Fixed go.test failure due to C-API argument type mismatch.
ClosedPublic

Authored by Chirag on Sep 6 2018, 1:17 AM.

Details

Summary

go.test was failing previously with error,

Command Output (stderr):

llvm.org/llvm/bindings/go/llvm

/tmp/lit_tmp_LMr8rj/gopath207816655/src/llvm.org/llvm/bindings/go/llvm/dibuilder.go:301: cannot use C.uint(t.Encoding) (type C.uint) as type C.LLVMDWARFTypeEncoding in argument to func literal

this patch fixes the argument type.

Diff Detail

Repository
rL LLVM

Event Timeline

Chirag created this revision.Sep 6 2018, 1:17 AM

Had the same issue when trying to build llgo and had to enable Go bindings, fixed in similar way locally.

Chirag added a comment.Sep 7 2018, 7:25 AM

Hello Kristina,

I was unable to find any bug for it and as it was a minor fix, went for changes directly. If you are aware of the bug number can you kindly link it?

I haven't ever filed it, just locally fixed it as I was messing around with trying to build llgo correctly (check the mailing lists for llgo).

pcc accepted this revision.Sep 7 2018, 10:07 AM

LGTM

This revision is now accepted and ready to land.Sep 7 2018, 10:07 AM

Can anyone kindly submit this? i do not have write access. Thanks.

Sure, one second.

This revision was automatically updated to reflect the committed changes.